328041 - File: Open filter prevents selection of local SVG files

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[jonathan chetwynd]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060207 Camino/1.0rc1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.1) Gecko/20060207 Camino/1.0rc1+

It is not possible to open any local SVG files using camino

Reproducible: Always




currently one has to control click etc...

can't understand how this slipped through?
aplogies if this is my error through ignorance

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Wevah, you've fixed some of these "filepicker doesn't recognize this extension/type code" bugs before.  Can you take this one?

Extensions: .svg, .svgz
Type Codes: SVG , SVGZ

Since SVG is supported natively now (instead of plugin content, which we don't include), we should probably also add these file types and extensions to the other image formats we claim to be able to view in Info*.plist.

Jonathan, you can view these in the meantime by dragging them from the Finder to the content area, or by command-option-dragging the file to the Camino icon or Dock icon.

Comment 2

[Samuel Sidler (old account; do not CC)]

If we're going to support SVG fully, we should get this for 1.0.1. Requesting approval for 1.0.1.

Comment 3

[Ludovic Hirlimann [:Usul]]

Attachment: adding support for svg files

Comment 4

[Ludovic Hirlimann [:Usul]]

Attachment: support svg files while opening such files

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 212747 [details] [diff] [review]
support svg files while opening such files

I have two minor issues with this patch:

1) It's missing the changes to Info*.plist (see my comment 1)

2) For cleanliness's sake, it seems like the svg entries should be with the image formats rather than with webloc (which will be getting ftploc and such to go along with it soon).

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to comment #5)
> (From update of attachment 212747 [details] [diff] [review] [edit])
> I have two minor issues with this patch:
> 
> 1) It's missing the changes to Info*.plist (see my comment 1)

Do you happen to know the name of the icon file for svg files ?


Ludovic

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #6)
> (In reply to comment #5)
> > 1) It's missing the changes to Info*.plist (see my comment 1)
> 
> Do you happen to know the name of the icon file for svg files ?

Just put it in the same block with the other image file types there, too, and it'll use whatever they use (or do not use).  We're just claiming to be a viewer, so I don't think we provide an icon.

Comment 8

[Ludovic Hirlimann [:Usul]]

(In reply to comment #1)
> Type Codes: SVG , SVGZ

Where did you get these ?

Comment 9

[Ludovic Hirlimann [:Usul]]

Attachment: complete patch with info plist.

File Types taken from Adobe's illustrator.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 213028 [details] [diff] [review]
complete patch with info plist.

I tested this patch and found two problems/typos:

The non-compressed SVG type code is 'SVG ', not 'SVG'.  

Also, the .svgz extension doesn't work in the Open File dialogue (due to the missing comma at the end of the line in the MainController.mm part).

Comment 11

[Ludovic Hirlimann [:Usul]]

Attachment: v 2.0

correcting Smokey's founding.

Comment 12

[Wevah (Nate Weaver)]

Comment on attachment 213299 [details] [diff] [review]
v 2.0

Looks good to me; r=me.

Comment 13

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 213299 [details] [diff] [review]
v 2.0

sr=pink

Comment 14

[Håkan Waara]

Checked in to trunk and branch.

Comment 15

[Mark Mentovai]

Fixed on CAMINO_1_0_1_MINIBRANCH and MOZILLA_1_8_0_BRANCH for cycles >=1.8.0.3
(Cm >= 1.0.2).