328089 - Additional Comments field columns are constant at 80 cols

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Rudolf Ramler]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; InfoPath.1)
Build Identifier: 

In bug# 11901 the line-wrapping policy has been changed. And the COMMENT_COLS are now set via a constant in Constants.pm - but this constant does not affect the with of the field "Additional Comments".

The template still contains the line
<textarea name="comment" id="comment" rows="10" cols="80">

as noted by others in bug# 11901 too.

Reproducible: Always

Comment 1

[Rudolf Ramler]

Attachment: Changes to edit.html.tmpl

Comment 2

[Rudolf Ramler]

Attachment: Changes to show_bug.cgi

Comment 3

[Max Kanat-Alexander]

Okay, I suppose this is a reasonable (if trivial) sort of enhancement. :-)

Comment 4

[Max Kanat-Alexander]

Comment on attachment 212627 [details] [diff] [review]
Changes to show_bug.cgi

Constants are available to the templates, you don't have to pass it in via $vars. Just use it directly.

Also, next patch, post the changes to both files as one "cvs diff -u" patch.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 212626 [details] [diff] [review]
Changes to edit.html.tmpl

You'll also need to get enter_bug and the "change several bugs at once" form, at the least. (Unless there's even another place that I'm forgetting.)

Comment 6

[Rudolf Ramler]

(In reply to comment #5)
> (From update of attachment 212626 [details] [diff] [review] [edit])
> You'll also need to get enter_bug and the "change several bugs at once" form,
> at the least. (Unless there's even another place that I'm forgetting.)

Okay, there are several templates that need to be changed. enter_bug is not affected since constants don't have to be passed from the cgi to the template.


Here are the templates that contain a textarea used for comments, all with a fixed width of 80 cols:

==> template\en\default\bug\edit.html.tmpl
(544): <textarea name="comment" id="comment" rows="10" cols="80"
==> template\en\default\bug\create\create.html.tmpl
(302): <textarea name="comment" rows="10" cols="80">
==> template\en\default\list\edit-multiple.html.tmpl
(188): <textarea id="comment" name="comment" rows="5" cols="80"></textarea><br>
==> template\en\default\attachment\create.html.tmpl
(170): <textarea wrap="soft" id="commment" name="comment" rows="6" cols="80"></textarea>
==> template\en\default\pages\linkify.html.tmpl
(33): <textarea cols="80" rows="20" name="text"></textarea>
==> template\en\default\bug\create\create-guided.html.tmpl
(336): <textarea rows="6" cols="80" name="comment"></textarea>
(384): <textarea rows="4" cols="80" name="reproduce_steps">
(401): <textarea rows="4" cols="80" name="actual_results"></textarea>
(413): <textarea rows="4" cols="80" name="expected_results"></textarea>
(425): <textarea rows="8" cols="80" name="additional_info"></textarea>


Furthermore, I'm unsure about the following. What's the purpose of this textarea? It isn't displayed anyway:

==> template\en\default\attachment\edit.html.tmpl
(249): <textarea id="editFrame" name="comment" style="height: 400px; width: 100%; display: none;" cols="80" wrap="soft"></textarea>

Comment 7

[Rudolf Ramler]

Attachment: Patch ver2 for templates

The patch affects the first five templates listed in the previous comment:

template/en/default/bug/edit.html.tmpl
template/en/default/bug/create/create.html.tmpl
template/en/default/list/edit-multiple.html.tmpl
template/en/default/pages/linkify.html.tmpl
template/en/default/bug/create/create-guided.html.tmpl

Comment 8

[Max Kanat-Alexander]

(In reply to comment #6)
> Furthermore, I'm unsure about the following. What's the purpose of this
> textarea? It isn't displayed anyway:
> [snip]

  It is displayed, but only if you have an HTML or text/plain attachment. Anyhow, it doesn't need to be modified.

Comment 9

[Max Kanat-Alexander]

Rudolf: I probably won't have time to review this again. Check out the Reviewer List and pick an appropriate reviewer for a template-only patch:

  http://www.bugzilla.org/docs/reviewer-list.html

Comment 10

[Rudolf Ramler]

Attachment: Patch ver3 for templates (for branches, bitrotten for tip)

This patch now includes all six placed that needed a change.

template/en/default/bug/edit.html.tmpl
template/en/default/bug/create/create.html.tmpl
template/en/default/list/edit-multiple.html.tmpl
template/en/default/attachment/create.html.tmpl
template/en/default/pages/linkify.html.tmpl
template/en/default/bug/create/create-guided.html.tmpl

Comment 11

[Vlad Dascalu]

Teoretically bug 11901 got into 2.20; however due to template changes we may want to approve this only for 2.22 and tip, or maybe tip-only.

Comment 12

[Tobias Sager]

I would love to see this in 2.22..
Thanks, Rudolf, for the patch.

Comment 13

[Vlad Dascalu]

Actually we still need the tip version. This patch works perfectly for branches, but on tip it is bitrotten by the check-in of bug 291459.

Rudolf: can you upload the tip version as well?

Comment 14

[Rudolf Ramler]

Attachment: Patch ver4 for templates (tip)

So this patch should work for the tip.

Comment 15

[Vlad Dascalu]

Cool! Requesting approval (david/myk: see comment 11)

Comment 16

[Dave Miller [:justdave]]

okay, problably still okay for the branches since we have separate patches.

Comment 17

[Vlad Dascalu]

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.25; previous revision: 1.24
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.72; previous revision: 1.71
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.28; previous revision: 1.27
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.56; previous revision: 1.55
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.152; previous revision: 1.151
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.33; previous revision: 1.32
done
Checking in template/en/default/pages/linkify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linkify.html.tmpl,v  <--  linkify.html.tmpl
new revision: 1.7; previous revision: 1.6
done

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.22.2.1; previous revision: 1.22
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.69.2.1; previous revision: 1.69
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.26.4.1; previous revision: 1.26
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.54.2.1; previous revision: 1.54
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.31.2.1; previous revision: 1.31
done
Checking in template/en/default/pages/linkify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linkify.html.tmpl,v  <--  linkify.html.tmpl
new revision: 1.5.6.1; previous revision: 1.5
done

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.20.4.1; previous revision: 1.20
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.60.2.5; previous revision: 1.60.2.4
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.26.2.1; previous revision: 1.26
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.51.2.2; previous revision: 1.51.2.1
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.26.2.3; previous revision: 1.26.2.2
done
Checking in template/en/default/pages/linkify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linkify.html.tmpl,v  <--  linkify.html.tmpl
new revision: 1.5.4.1; previous revision: 1.5
done

Comment 18

[Vlad Dascalu]

I've applied FILTER none to constants.COMMENT_COLS to make tinderbox happy.

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.22.2.2; previous revision: 1.22.2.1
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.69.2.2; previous revision: 1.69.2.1
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.26.4.2; previous revision: 1.26.4.1
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.54.2.2; previous revision: 1.54.2.1
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.31.2.2; previous revision: 1.31.2.1
done
Checking in template/en/default/pages/linkify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linkify.html.tmpl,v  <--  linkify.html.tmpl
new revision: 1.5.6.2; previous revision: 1.5.6.1
done

Checking in template/en/default/attachment/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.20.4.2; previous revision: 1.20.4.1
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.60.2.6; previous revision: 1.60.2.5
done
Checking in template/en/default/bug/create/create-guided.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create-guided.html.tmpl,v  <--  create-guided.html.tmpl
new revision: 1.26.2.2; previous revision: 1.26.2.1
done
Checking in template/en/default/bug/create/create.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/create/create.html.tmpl,v  <--  create.html.tmpl
new revision: 1.51.2.3; previous revision: 1.51.2.2
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v  <--  edit-multiple.html.tmpl
new revision: 1.26.2.4; previous revision: 1.26.2.3
done
Checking in template/en/default/pages/linkify.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/pages/linkify.html.tmpl,v  <--  linkify.html.tmpl
new revision: 1.5.4.2; previous revision: 1.5.4.1
done

Comment 19

[Vlad Dascalu]

On tip I accidentally commited an additional change, backing it out:

Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.153; previous revision: 1.152
done