328134 - margin fields in page setup accept '^' and '|' characters

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[rcampbel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060123 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060123 Firefox/1.5.0.1

The margins allow users to enter the '^' character, which it always defaults back to '0' for the margin size.

Reproducible: Always

Steps to Reproduce:
**Margin Box is what I am calling the "dotted" lines showing the pages margins.**

1. Go to File->Page Setup...
2. Go to the Margins & Header/Footer Tab
3. Enter '^' in any of the margin boxes
4. Notice Margin Box is redrawn
5. Close Page Setup window by selecting the OK button, or pressing your "enter" key
6. File->Page Setup...
7. Go to the Margins & Header/Footer tab
8. Notice value of margin that had '^' entered and size of Margin Box
Actual Results:  
Margin with '^' entered defaults to '0' and the Margin Box is drawn with a zero value for that/those margins.  

*Can enter combination of numbers and '^'s, result is still the same.*

Expected Results:  
I would expect the '^' character to be blocked by an input validator, or the character hold a mathematical function.

*I experimented with several variations to try and find a mathematical function or relevance for the '^' character.*

Comment 1

[Josh Birnbaum]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060214 Firefox/1.6a1.

The source for this appears to be http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/printPageSetup.js#113

This function checks that the new margin value is really a double, and removes invalid characters using value.replace(/[^\.|^0-9]/g,"").  I think that needs to be value.replace(/[^\.|0-9]/g,"") but I don't know enough JS to say without testing it.

This code also appears in the toolkit directory: http://lxr.mozilla.org/seamonkey/source/toolkit/components/printing/content/printPageSetup.js#113

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: fix bogus regexp usage

This dates back to when the file was initially added in 2002.

Comment 3

[[e-mail]]

Comment on attachment 212780 [details] [diff] [review]
fix bogus regexp usage

> function checkDouble(element)
> {
>   var value = element.value;
>   if (value && value.length > 0) {
>-    value = value.replace(/[^\.|^0-9]/g,"");
>+    value = value.replace(/[^\.0-9]/g,"");
>     if (!value) value = "";
>     element.value = value;
>   }
> }
Nits: \ is also unnecessary because . isn't special inside []; space after ,

Bonus points for extra cleanup:
>     if (!value) value = "";
value can't be null here (code may originally have used match?)
>   if (value && value.length > 0) {
if (value) fails unless value.length > 0
Then when you consider that the code has no harmful effects when value == "" you can reduce this function to one line :-)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Attachment: for checkin

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/xpfe/global/resources/content/printPageSetup.js 	1.14.28.1
mozilla/toolkit/components/printing/content/printPageSetup.js 	1.3.8.1
mozilla/toolkit/components/printing/content/printPageSetup.js 	1.5
mozilla/xpfe/global/resources/content/printPageSetup.js 	1.16