328191 - Can't delete history entries

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

In the places view there is no response to pressing the delete or backspace key. When right click on a history entry "Delete" is greyed out.

When autocompleting in the location bar, selecting an entry using the up/down arrow keys and then pressing del does remove the entry, but only until you start autocompleting again.

This was observed with a DIY 1.8branch build (checkout Wed Feb 22 02:35:54 PST 2006).

Comment 1

[Brett Wilson]

*** Bug 329366 has been marked as a duplicate of this bug. ***

Comment 2

[Ryuichi KUBUKI]

Doesn't work here either, "Delete" is greyed out in the right-click context menu.

--> All

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060308 Firefox/1.6a1

For the keyboard shortcuts, I think it's in Bug 325091.

Comment 3

[Hideo Oshima]

I can delete history entries now.
Is this fixed by patch of bug 329272?

Comment 4

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060310 Firefox/1.6a1 ID:2006031020 [cairo]

this seems fixed indeed

Comment 5

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060313 Firefox/1.6a1 ID:2006031322
No, this is broken.

Comment 6

[Hideo Oshima]

Ria, what is broken?
I can still delete history entories.

Comment 7

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #6)
> Ria, what is broken?
> I can still delete history entories.
>
Argh. I was a bit absent-minded. I could not delete search results, so I searched for this bug and found Bug 329366 but that was duped against this one and I did not look at the summary.
But you're right (of course); I can delete history but not search results in history. Not sure what I shall do now. Reopen Bug 329366 or file a new one?
  

Comment 8

[Hideo Oshima]

(In reply to comment #7)
> I can delete history but not search results in
> history. Not sure what I shall do now. Reopen Bug 329366 or file a new one?

I think you should reopen bug 329366.
I can reproduce bug 329366 too.

Comment 9

[Ryuichi KUBUKI]

Still I can't delete it in the location box, just like

>When autocompleting in the location bar, selecting an entry using the up/down
>arrow keys and then pressing del does remove the entry, but only until you
>start autocompleting again.

with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060314 Firefox/1.6a1 (non-Cairo)

Comment 10

[Hideo Oshima]

(In reply to comment #9)
> Still I can't delete it in the location box, just like
> 
> >When autocompleting in the location bar, selecting an entry using the up/down
> >arrow keys and then pressing del does remove the entry, but only until you
> >start autocompleting again.

Above is reproducible for Fx 1.5.0.1/WinXP release.
I don't think it is a Places' bug.
It should be open new bug.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #10)
> Above is reproducible for Fx 1.5.0.1/WinXP release.
> I don't think it is a Places' bug.
> It should be open new bug.

The correct key combination to use with 1.5.x.y builds is shift-delete, which works fine for me, so there is no bug to open.

Bug 241774 switched the keystroke from shift-delete to delete, a change which landed on the mozilla1.8 branch (for Firefox 2) and on the trunk during 2006-01-31.

Comment 12

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #11)
>
> The correct key combination to use with 1.5.x.y builds is shift-delete, which
> works fine for me, so there is no bug to open.
> 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060314 Firefox/1.6a1
Haha, this is weird, for neither Delete nor Shift+Delete deletes them here.
Did the same test on 1.5.0.1 and with this build I had no problem.

Comment 13

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #12)
Also observed by a family member with the latest branch.
See Bug 330541.

Comment 14

[Hideo Oshima]

(In reply to comment #11)
> (In reply to comment #10)
> > Above is reproducible for Fx 1.5.0.1/WinXP release.
> > I don't think it is a Places' bug.
> > It should be open new bug.
> 
> The correct key combination to use with 1.5.x.y builds is shift-delete, which
> works fine for me, so there is no bug to open.

I'm sorry.¡¡I made a mistake.

Comment 15

[Ria Klaassen (not reading all bugmail)]

Deleting history items is broken again.

Comment 16

[Hideo Oshima]

(In reply to comment #15)
> Deleting history items is broken again.

Yes. I confirmed with trunk/Linux.

Comment 17

[Peter van der Woude [:Peter6]]

delete history in menu toolbar -> History is broken
delete history in places -> history is grayed out
delete history in options -> privacy -> history works (but you have to give it some time)

Comment 18

[Joe Hughes]

Just a minor scope suggestion: someone on m.feedback asked for the ability to select and delete multiple history entries at once, which sounds like a good idea if we don't already do that.

Comment 19

[Brett Wilson]

(In reply to comment #18)
> Just a minor scope suggestion: someone on m.feedback asked for the ability to
> select and delete multiple history entries at once, which sounds like a good
> idea if we don't already do that.

Control and shift work like normal.

Comment 20

[Steve England [:stevee]]

*** Bug 331565 has been marked as a duplicate of this bug. ***

Comment 21

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

this patch;
- adds label/tooltip to places icon in browser toolbar at appropriate time
- makes sure places toolbar has the right context menu for customization
- makes sure edit/clipboard commands show in context menu for separators
- ensures history items can be deleted
- fixes bug in nodeIsRemoteContainer (elaborate impl)
- fixes bug in selectionOverlapsSystemArea
- fixes exception thrown in canPaste (getAnyTransferData)
- allows .insertionPoint to be null
- properly sets up active view in menupopups (was not getting set before, leading to js errors sometimes when opening context menus on menus)
- fix js error after deleting a folder
- middle clicking item in places organizer should open new tab

Comment 22

[Annie Sullivan]

Comment on attachment 216494 [details] [diff] [review]
patch

>
>   nodeIsRemoteContainer: function PC_nodeIsRemoteContainer(node) {
>-      const NHRN = Ci.nsINavHistoryResultNode;
>-      if (node.type == NHRN.RESULT_TYPE_REMOTE_CONTAINER)
>-        return true;
>-      if (node.type == NHRN.RESULT_TYPE_FOLDER)
>-        return asContainer(node).remoteContainerType != "";
>-      
>-      return false;
>+    const NHRN = Ci.nsINavHistoryResultNode;
>+    return node.type == NHRN.RESULT_TYPE_REMOTE_CONTAINER;
>   },

This is incorrect.  There are actually two types of remote containers--ones that have "real" bookmark children, like livemarks, are implemented as folders with a remoteContainerType.  Ones that dynamically generate children that are not stored as bookmarks have type RESULT_TYPE_REMOTE_CONTAINER.  See comment 11 of bug 329743.

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: new patch, reverts nodeIsRemoteContainer

Also sprinkles in a null check in updateLivemarkCommands

Comment 24

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed as part of 328191, br & trunk

Comment 25

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv