328211 - return path for undeliverable mail do not work for smtp setting.

Status: RESOLVED WORKSFORME

(Bugzilla :: Email Notifications, enhancement)

Description

[Christian Volkmann]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060129 SUSE/1.0-0 SeaMonkey/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.1) Gecko/20060129 SUSE/1.0-0 SeaMonkey/1.0

An email address was invalid. Parameter smtp is set.
The bounce mail did not find the way to the maintainer.


Reproducible: Always

Steps to Reproduce:
1.parameter mail_delivery_method=smtp
2.enter any invalid not deliverable email
3.assign a bug
4.do some action which should send an email
5.check maintainer email box for the bounce message

Actual Results:  
No bounce sent to maintainer ( usage of note smtp )
tcpdump of smtp-traffic:
..
EHLO localhost.localdomain
...
MAIL FROM:<[e-mail]>
...

Expected Results:  
bounce mail to maintainer ( usage of note smtp )
tcpdump of smtp-traffic:
..
EHLO bugzilla.server
...
MAIL FROM:<[e-mail]>
...

This patch worked for me:

--- Bugzilla/BugMail.pm     2006-02-21 15:18:00.000000000 +0100
+++ Bugzilla/BugMail.pm 2006-02-22 19:32:50.578383411 +0100
@@ -635,6 +635,16 @@
         push @args, "-ODeliveryMode=deferred";
     }
     if (Param("mail_delivery_method") eq "smtp") {
+        # Solve bounce problem ( no return path found )
+        # MAILADDRESS not set: Otherwise perl uses [e-mail]
+        my $servername = Param("maintainer");
+        $ENV{MAILADDRESS} = $servername;
+
+        # fill "ehlo" for smtp with domain of the maintainer
+        # localhost.localdomain is used if Hello is not set
+        $servername =~ s/.*\@// ;
+        push @args, Hello => $servername;
+
         push @args, Server => Param("smtpserver");
     }
     my $mailer = new Mail::Mailer Param("mail_delivery_method"), @args;
---

Beware of all the bounce messages ;-)

Comment 1

[Max Kanat-Alexander]

This isn't a bug, it's a missing feature. Your version of Bugzilla doesn't support setting the SMTP Envelope From address. I believe we've fixed this in CVS or in 2.22, and this is a dup of something.

Comment 2

[Christian Volkmann]

Had a look into 2.22rc1: ENV{MAILADDRESS} is set with "from".

Suggest to set also "Hello" to avoid the usage of localhost.localdomain
 my $servername = param("urlbase");
 $servername = s#.*//## ;
 $servername = s#/.*## ;
 push @args, Hello => $servername;

Christian

Comment 3

[Frédéric Buclin]

Hello is defined since Bugzilla 3.0, see bug 353711.