Closed Bug 328218 Opened 15 years ago Closed 15 years ago

don't allow creating multiple io services

Categories

(Core :: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.8.1

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Some mailnews code was using createInstance on the IO service. Now that the destructor clears out gIOService, this was a pretty bad thing. We should prevent this kind of crash.
Attached patch patchSplinter Review
Attachment #212811 - Flags: superreview?(darin)
Attachment #212811 - Flags: review?(darin)
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8.1
(bug 328219 was the mailnews crash)
Attachment #212811 - Flags: approval-branch-1.8.1?(darin)
Comment on attachment 212811 [details] [diff] [review]
patch

When is the singleton cleared?  Doesn't this leak gIOService?
Comment on attachment 212811 [details] [diff] [review]
patch

nevermind.  I missed the fact that you return early in GetInstance when creating the IO service for the first time.  Looks good!

r+sr+a=darin
Attachment #212811 - Flags: superreview?(darin)
Attachment #212811 - Flags: superreview+
Attachment #212811 - Flags: review?(darin)
Attachment #212811 - Flags: review+
Attachment #212811 - Flags: approval-branch-1.8.1?(darin)
Attachment #212811 - Flags: approval-branch-1.8.1+
yeah, I initially had a single addref in that function, but it is important to addref before calling init so having two seemed easiest.
s/NULL/nsnull/ perhaps?
With a build including this patch, all the crashing hangs etc. using Forecastfox Enhanced 0.8.5.0.1 are resolved.
that's still a bug in the extension though.
fixed on trunk and the 1.8 branch, with nsnull
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.