Closed Bug 328218 Opened 15 years ago Closed 15 years ago
don't allow creating multiple io services
Some mailnews code was using createInstance on the IO service. Now that the destructor clears out gIOService, this was a pretty bad thing. We should prevent this kind of crash.
15 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8.1
(bug 328219 was the mailnews crash)
15 years ago
Comment on attachment 212811 [details] [diff] [review] patch When is the singleton cleared? Doesn't this leak gIOService?
Comment on attachment 212811 [details] [diff] [review] patch nevermind. I missed the fact that you return early in GetInstance when creating the IO service for the first time. Looks good! r+sr+a=darin
yeah, I initially had a single addref in that function, but it is important to addref before calling init so having two seemed easiest.
With a build including this patch, all the crashing hangs etc. using Forecastfox Enhanced 0.8.5.0.1 are resolved.
that's still a bug in the extension though.
fixed on trunk and the 1.8 branch, with nsnull
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.