328218 - don't allow creating multiple io services

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Some mailnews code was using createInstance on the IO service. Now that the destructor clears out gIOService, this was a pretty bad thing. We should prevent this kind of crash.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

(bug 328219 was the mailnews crash)

Comment 3

[Darin Fisher]

Comment on attachment 212811 [details] [diff] [review]
patch

When is the singleton cleared?  Doesn't this leak gIOService?

Comment 4

[Darin Fisher]

Comment on attachment 212811 [details] [diff] [review]
patch

nevermind.  I missed the fact that you return early in GetInstance when creating the IO service for the first time.  Looks good!

r+sr+a=darin

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

yeah, I initially had a single addref in that function, but it is important to addref before calling init so having two seemed easiest.

Comment 6

[Boris Zbarsky [:bzbarsky]]

s/NULL/nsnull/ perhaps?

Comment 7

[Bill Gianopoulos [:WG9s]]

With a build including this patch, all the crashing hangs etc. using Forecastfox Enhanced 0.8.5.0.1 are resolved.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

that's still a bug in the extension though.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk and the 1.8 branch, with nsnull