328340 - [FIX]No focus outline shown with select drop down controls

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Martijn Wargers (dead)]

To see the bug, just click on one of the select drop down controls in bugzilla.
When the control has the focus, you should see a focus outline, which doesn't happen in current Cairo trunk builds.

Comment 1

[:deanis74]

Related to bug 326550?

Comment 2

[Daniel C]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060407 Firefox/3.0a1

See this on Linux too.

Comment 3

[Niro]

Regression range:
20060222 - 20060226
I can't test builds inside that range. 
Maybe someone else can tighter the range.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We looked at this in the triage meeting (me, stuart, vlad, bz), and in a few seconds of talking about it determined that
nsComboboxControlFrame::PaintFocus calls
   aRenderingContext.SetColor(0);
which presumably used to ignore alpha, but no longer does.  It should probably use NS_RGB(0,0,0).

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Yeah, this fixes it

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 244513 [details] [diff] [review]
Yeah, this fixes it

I was about to attach the same patch.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that we should not use NS_RGB(0, 0, 0). Because on cairo build, we cannot use invert drawing. Therefore, we are using foreground color for the focus rect in other contents. I think that we should use foreground color in this case too.

Comment 9

[Boris Zbarsky [:bzbarsky]]

That's fine; this was just restoring the existing behavior.  Please file a separate bug if you feel the behavior should change in general.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We should probably add support for invert drawing at some point, though.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I filed bug 359496 for the comment 8.

(In reply to comment #10)
> We should probably add support for invert drawing at some point, though.

Yeah, I filed bug 359497 too. But I have no idea to fix the bug...