Closed Bug 328383 Opened 19 years ago Closed 19 years ago

1.8.0 Mac Full MAR files have incorrect sizes of 54 bytes

Categories

(AUS Graveyard :: Systems, defect)

Product:
AUS Graveyard
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
4.x (triaged)

People

(Reporter: mscott, Assigned: mark)

Details

Similar to what we were seeing in Bug 327140, but Mac only. Starting today, 02/23, the full MAR files for Mac OS X for Firefox and Thunderbird on the 1.8.0 branch have bogus sizes of 54 bytes. Yesterday the build machines generated full MAR files that work. I've done a couple respins of Thunderbird today and they still have the bogus size. See: http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2006-02-23-04-mozilla1.8.0/ and http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2006-02-23-03-mozilla1.8.0 Related to the packaging changes we took on the 1.8.0 branch yesterday for supportin universal binaries on the Mac perhaps?
I doubt it, but hey, it's possible. Can someone point me to the codepath for .mar generation?
Filed bug 328391 for universal .mar generation, but that's not what's going on here. None of the tinderboxen are building universal yet (since none meet the requirements for universal builds yet.)
Status: NEW → ASSIGNED
Assignee: nobody → mark
Status: ASSIGNED → NEW
From your most recent respin build log: Generating complete update... make -C /builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/tools/update-packaging full-update STAGE_DIR=/builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/dist/install/2006-02-23-15-mozilla1.8.0/build.12236 DIST=/builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/dist AB_CD=en-US mkdir -p /builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/dist/install/2006-02-23-15-mozilla1.8.0/build.12236 MAR=/builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/dist/host/bin/mar ./make_full_update.sh "/builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/dist/install/2006-02-23-15-mozilla1.8.0/build.12236/thunderbird-1.5.0.2.en-US.mac.mar" "/builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/dist/thunderbird/Thunderbird.app" ./make_full_update.sh: line 1: cd: /builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/dist/thunderbird/Thunderbird.app: No such file or directory That's bad. (The tree should be red when this happens.) But what happened to dist/thunderbird/Thunderbird.app? It's supposed to be created during packaging (incidentally, the dmgs produced by these spins don't contain any app.) Well, here's what happens during packaging: cd ../../dist; /builds/tinderbox/Tb-Mozilla1.8.0/Darwin_7.9.0_Depend/mozilla/build/package/mac_osx/pkg-dmg --source "universal/thunderbird" --target "thunderbird-1.5.0.2.en-US.mac.dmg" --volname "Thunderbird" --copy "branding/dsstore:/.DS_Store" --mkdir /.background --copy "branding/background.png:/.background" --icon "branding/disk.icns" --resource "branding/license.r" universal/thunderbird. That's bad. That's only supposed to happen when you're doing a universal build, which this sure isn't. pkg-dmg should probably fail here (I'll file a bug on myself). But why is this happening? packager.mk has some pretty careful ifdefs in it (I know, since I just put them there) that only do universal packaging if UNIVERSAL_BINARY is set. Off to the tinderbox we go. Here's what I found in autoconf.mk: UNIVERSAL_BINARY= @UNIVERSAL_BINARY@ Aha! Something's not getting AC_SUBSTed! Nobody ever set up cltbld@egg to run autoconf on this branch. I checked an updated configure script in on 1.8.0.
Status: NEW → RESOLVED
Closed: 19 years ago
OS: Windows XP → MacOS X
Hardware: PC → Macintosh
Resolution: --- → FIXED
Filed followups 328401 (dmg) and 328403 (mar) to signal failure when the stuff to package is missing.
Nice work Mark.
Triggering respins of Fx-1.8.0 and Tb-1.8.0.
Thanks!
QA Contact: nobody → systems
You need to log in before you can comment on or make changes to this bug.