328434 - Move GroupIsActive into post_bug.cgi

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

The only script that uses the GroupIsActive sub from globals.pl is process_bug.cgi. Let's just move it into that script.

Other people who need to find out if a group is active should create a group object and check the is_active bit on it.

Comment 1

[Max Kanat-Alexander]

Oh, actually, I mean post_bug.cgi. :-)

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Okay, here's the patch. Very straightforward. I also changed the function to use DBI stuff instead of SendSQL.

I tested this; it works.

Comment 3

[Frédéric Buclin]

Comment on attachment 213022 [details] [diff] [review]
v1


>+sub GroupIsActive {
>+    my ($group_id) = @_;
>+    $group_id ||= 0;
>+    trick_taint($group_id);


Please write detaint_natural() instead of trick_taint() on checkin.

Comment 4

[Max Kanat-Alexander]

Okay, did the checkin fix.

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.352; previous revision: 1.351
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.137; previous revision: 1.136
done

Comment 5

[Max Kanat-Alexander]

Attachment: Checked-in version

Here's the version that I checked in, with the checkin fix.