If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move GroupIsActive into post_bug.cgi

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Bugzilla-General
--
enhancement
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

2.23
Bugzilla 3.0
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
The only script that uses the GroupIsActive sub from globals.pl is process_bug.cgi. Let's just move it into that script.

Other people who need to find out if a group is active should create a group object and check the is_active bit on it.
(Assignee)

Comment 1

12 years ago
Oh, actually, I mean post_bug.cgi. :-)
Assignee: general → mkanat
Summary: Move GroupIsActive into process_bug.cgi → Move GroupIsActive into post_bug.cgi
(Assignee)

Comment 2

12 years ago
Created attachment 213022 [details] [diff] [review]
v1

Okay, here's the patch. Very straightforward. I also changed the function to use DBI stuff instead of SendSQL.

I tested this; it works.
Attachment #213022 - Flags: review?(wicked)

Updated

12 years ago
Blocks: 328437
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Attachment #213022 - Flags: review?(wicked) → review+
Flags: approval?

Comment 3

12 years ago
Comment on attachment 213022 [details] [diff] [review]
v1


>+sub GroupIsActive {
>+    my ($group_id) = @_;
>+    $group_id ||= 0;
>+    trick_taint($group_id);


Please write detaint_natural() instead of trick_taint() on checkin.
Flags: approval? → approval+
(Assignee)

Comment 4

12 years ago
Okay, did the checkin fix.

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.352; previous revision: 1.351
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.137; previous revision: 1.136
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

12 years ago
Created attachment 213638 [details] [diff] [review]
Checked-in version

Here's the version that I checked in, with the checkin fix.
Attachment #213022 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.