328558 - "ASSERTION: we rather crash than hang" when using WSDLLoader

Status: RESOLVED WORKSFORME

(Core Graveyard :: Web Services, defect)

Description

[Jesse Ruderman]

###!!! ASSERTION: we rather crash than hang: '!(mState & XML_HTTP_REQUEST_SYNCLOOPING)', file mozilla/extensions/xmlextras/base/src/nsXMLHttpRequest.cpp, line 282

What does "we rather crash than hang" mean, anyway?  That string appears in Mozilla source several times.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Jesse Ruderman]

The testcase has to be loaded from a file: URL to produce the assertion.

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Hmm, so it didn't crash? It was supposed to...

I remember we put these things in the code in situations that should not happen, but if it ever did happen the app would crash and we might get a talkback report. With hang there is no talkback. So, crashing seemed the best course of action.

Comment 4

[Jesse Ruderman]

This still happens on trunk (with the testcase loaded from a file: URL).

Comment 5

[Jesse Ruderman]

SOAP is no longer built by default, so this doesn't affect Firefox any more.  (SOAP support was dropped in bug 332174.)

Comment 6

[Martijn Wargers (dead)]

Attachment: testcase2

I'm also seeing this assertion when xmlhttprequest is used on a non-existing file.

Comment 7

[Martijn Wargers (dead)]

The assertion seems to be delayed, it comes up after 10 seconds or so.

Comment 8

[Jesse Ruderman]

I get a security exception when I load testcase2 as a local file.

Comment 9

[Jesse Ruderman]

Btw, I have never seen this crash *or* hang.  But it's an NS_ABORT_IF_FALSE, which means it will abort soon if bug 429930 is fixed (in debug builds only).

Comment 10

[Jesse Ruderman]

I think this code is totally gone now.

http://mxr.mozilla.org/mozilla-central/search?string=WSDLLoader