328585 - Handle the size of the modeless and modal <message>s in a better way

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Although I'll XBLize some part of the <message> at some point, the
handling of the modal and modeless messages will probably stay in C++.
Atm the size of the message windows is not always right.
A patch, which fixes the problems on my Linux machines, is coming.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: proposed patch

Comment 2

[Allan Beaufour]

Comment on attachment 213186 [details] [diff] [review]
proposed patch

(In reply to comment #1)
> Created an attachment (id=213186) [edit]
> proposed patch

Looks good to me, but I would like to see confirmation of the fix on Windows and Mac before checkin.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #2)
> (From update of attachment 213186 [details] [diff] [review] [edit])
> (In reply to comment #1)
> > Created an attachment (id=213186) [edit]
> > proposed patch
> 
> Looks good to me, but I would like to see confirmation of the fix on Windows
> and Mac before checkin.
> 
I have only Linux machines. 
Aaron, could you test on Windows?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Doron tested this on Windows and noticed that if scripts aren't allowed 
resize windows, this doesn't work properly :( Have to think some better way ...

Comment 5

[Doron Rosenberg (IBM)]

(In reply to comment #4)
> Doron tested this on Windows and noticed that if scripts aren't allowed 
> resize windows, this doesn't work properly :( Have to think some better way ...
> 

I think the patch is good enough for now, the default setting is to allow resizing of windows.

Comment 6

[Allan Beaufour]

This just needs to be checked in right?

Comment 7

[Allan Beaufour]

(In reply to comment #6)
> This just needs to be checked in right?

I take the silence as "no objections" :)

Checked into trunk. I'll post a followup-bug for the case when resize is not allowed.