328641 - Make Bugzilla::Util not depend on Bugzilla::Config

Status: RESOLVED DUPLICATE of bug 328642

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

Right now Bugzilla::Util depends on Bugzilla::Config for perform_substs and validate_email_syntax. This is a problem because Bugzilla::Util is used all over the place, and more than once I've run into a very long dependency loop because of it. Right now it's blocking my work on bug 328637. (Bugzilla::Config::BugFields will depend on Bugzilla::Field, which uses Bugzilla::Util, which uses Bugzilla::Config, which uses Bugzilla::Config::BugFields.)

I think both of these functions could be moved elsewhere. It's possible that perform_substs could even be moved into Bugzilla::Config itself. validate_email_syntax should be fine in Bugzilla::User, I'd imagine, even though it has non-user uses.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

This is pretty straightforward. I just move the functions into places where they can live.

Comment 2

[Max Kanat-Alexander]

Attachment: v1.1

The first version was missing an EXPORT in Bugzilla::Config.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 213244 [details] [diff] [review]
v1.1

LpSolit pointed out that I'd also have to move format_time. But if anything belongs in Bugzilla::Util, it's really format_time. So I'd rather not move it, and just fix this in a more architecturally-sound way.

Comment 4

[Max Kanat-Alexander]

*** This bug has been marked as a duplicate of 328642 ***