Closed
Bug 328769
Opened 18 years ago
Closed 18 years ago
assertion running e4x tests
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.9alpha1
People
(Reporter: mrbkap, Assigned: mrbkap)
References
Details
(Keywords: assertion, verified1.8.0.2, verified1.8.1, Whiteboard: [patch][rft-dl])
Attachments
(1 file)
2.20 KB,
patch
|
mrbkap
:
review+
brendan
:
approval-branch-1.8.1+
dveditz
:
approval1.8.0.2+
|
Details | Diff | Splinter Review |
bug 328249 added an assertion that we never see lists of length > 1 in CheckCycle, but this isn't the case, thanks to Insert. Instead of trying to handle lists in CheckCycle, we should simply only pass elements to it, and do the looping (and flattening) elsewhere.
Assignee | ||
Updated•18 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [patch]
Assignee | ||
Comment 1•18 years ago
|
||
This has r=brendan
Assignee: general → mrbkap
Attachment #213361 -
Flags: review+
Assignee | ||
Comment 2•18 years ago
|
||
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•18 years ago
|
||
Comment on attachment 213361 [details] [diff] [review] Fix Since bug 328249 was checked into the branch, we need this too.
Attachment #213361 -
Flags: approval1.8.0.2?
Attachment #213361 -
Flags: approval-branch-1.8.1?(brendan)
Comment 4•18 years ago
|
||
Comment on attachment 213361 [details] [diff] [review] Fix This is a followup fix to the 1.8.0 branch, safe for 1.8.0.2 if that's still taking fixes. /be
Attachment #213361 -
Flags: approval-branch-1.8.1?(brendan) → approval-branch-1.8.1+
Comment 5•18 years ago
|
||
Comment on attachment 213361 [details] [diff] [review] Fix approved for 1.8.0 branch, a=dveditz
Attachment #213361 -
Flags: approval1.8.0.2? → approval1.8.0.2+
Assignee | ||
Comment 6•18 years ago
|
||
Fix checked into the 1.8 branches.
Keywords: fixed1.8.0.2,
fixed1.8.1
Comment 7•18 years ago
|
||
please provide testcase or test guidance for this fix.
Whiteboard: [patch] → [patch][tcn-dl]
Assignee | ||
Comment 8•18 years ago
|
||
The testcase in js/tests/e4x/Expressions/11.6.1.js covers this.
Comment 9•18 years ago
|
||
practically every test failed with this bug. I did not see any crashes in my nightly build testing and am running debug build testing now. I will verify it when I complete.
Updated•18 years ago
|
Whiteboard: [patch][tcn-dl] → [patch][rft-dl]
Comment 10•18 years ago
|
||
no longer see the failures which resulted from this bug.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•