Last Comment Bug 328769 - assertion running e4x tests
: assertion running e4x tests
: assertion, verified1.8.0.2, verified1.8.1
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
P1 normal (vote)
: mozilla1.9alpha1
Assigned To: Blake Kaplan (:mrbkap)
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 328249
  Show dependency treegraph
Reported: 2006-02-27 12:31 PST by Blake Kaplan (:mrbkap)
Modified: 2006-11-10 12:22 PST (History)
4 users (show)
bob: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix (2.20 KB, patch)
2006-02-27 12:32 PST, Blake Kaplan (:mrbkap)
mrbkap: review+
brendan: approval‑branch‑1.8.1+
dveditz: approval1.8.0.2+
Details | Diff | Splinter Review

Description User image Blake Kaplan (:mrbkap) 2006-02-27 12:31:07 PST
bug 328249 added an assertion that we never see lists of length > 1 in CheckCycle, but this isn't the case, thanks to Insert. Instead of trying to handle lists in CheckCycle, we should simply only pass elements to it, and do the looping (and flattening) elsewhere.
Comment 1 User image Blake Kaplan (:mrbkap) 2006-02-27 12:32:31 PST
Created attachment 213361 [details] [diff] [review]

This has r=brendan
Comment 2 User image Blake Kaplan (:mrbkap) 2006-02-27 12:34:13 PST
Fix checked into trunk.
Comment 3 User image Blake Kaplan (:mrbkap) 2006-02-27 12:36:15 PST
Comment on attachment 213361 [details] [diff] [review]

Since bug 328249 was checked into the branch, we need this too.
Comment 4 User image Brendan Eich [:brendan] 2006-02-27 13:09:51 PST
Comment on attachment 213361 [details] [diff] [review]

This is a followup fix to the 1.8.0 branch, safe for if that's still taking fixes.

Comment 5 User image Daniel Veditz [:dveditz] 2006-02-27 18:33:33 PST
Comment on attachment 213361 [details] [diff] [review]

approved for 1.8.0 branch, a=dveditz
Comment 6 User image Blake Kaplan (:mrbkap) 2006-02-27 18:40:10 PST
Fix checked into the 1.8 branches.
Comment 7 User image Dave Liebreich [:davel] 2006-03-02 13:50:30 PST
please provide testcase or test guidance for this fix.
Comment 8 User image Blake Kaplan (:mrbkap) 2006-03-02 13:52:15 PST
The testcase in js/tests/e4x/Expressions/11.6.1.js covers this.
Comment 9 User image Bob Clary [:bc:] 2006-03-02 13:55:25 PST
practically every test failed with this bug. I did not see any crashes in my nightly build testing and am running debug build testing now. I will verify it when I complete.
Comment 10 User image Bob Clary [:bc:] 2006-03-07 15:20:23 PST
no longer see the failures which resulted from this bug.

Note You need to log in before you can comment on or make changes to this bug.