bug 328249 added an assertion that we never see lists of length > 1 in CheckCycle, but this isn't the case, thanks to Insert. Instead of trying to handle lists in CheckCycle, we should simply only pass elements to it, and do the looping (and flattening) elsewhere.
Status: NEW → ASSIGNED
Priority: -- → P1
Created attachment 213361 [details] [diff] [review] Fix This has r=brendan
Assignee: general → mrbkap
Attachment #213361 - Flags: review+
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Comment on attachment 213361 [details] [diff] [review] Fix Since bug 328249 was checked into the branch, we need this too.
Comment on attachment 213361 [details] [diff] [review] Fix This is a followup fix to the 1.8.0 branch, safe for 22.214.171.124 if that's still taking fixes. /be
Attachment #213361 - Flags: approval-branch-1.8.1?(brendan) → approval-branch-1.8.1+
Comment on attachment 213361 [details] [diff] [review] Fix approved for 1.8.0 branch, a=dveditz
Attachment #213361 - Flags: approval126.96.36.199? → approval188.8.131.52+
Fix checked into the 1.8 branches.
Keywords: fixed184.108.40.206, fixed1.8.1
please provide testcase or test guidance for this fix.
Whiteboard: [patch] → [patch][tcn-dl]
The testcase in js/tests/e4x/Expressions/11.6.1.js covers this.
practically every test failed with this bug. I did not see any crashes in my nightly build testing and am running debug build testing now. I will verify it when I complete.
no longer see the failures which resulted from this bug.
Status: RESOLVED → VERIFIED
Keywords: fixed220.127.116.11, fixed1.8.1 → verified18.104.22.168, verified1.8.1
You need to log in before you can comment on or make changes to this bug.