assertion running e4x tests

VERIFIED FIXED in mozilla1.9alpha1

Status

()

Core
JavaScript Engine
P1
normal
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

({assertion, verified1.8.0.2, verified1.8.1})

Trunk
mozilla1.9alpha1
assertion, verified1.8.0.2, verified1.8.1
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch][rft-dl])

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
bug 328249 added an assertion that we never see lists of length > 1 in CheckCycle, but this isn't the case, thanks to Insert. Instead of trying to handle lists in CheckCycle, we should simply only pass elements to it, and do the looping (and flattening) elsewhere.
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [patch]
(Assignee)

Comment 1

11 years ago
Created attachment 213361 [details] [diff] [review]
Fix

This has r=brendan
Assignee: general → mrbkap
Attachment #213361 - Flags: review+
(Assignee)

Comment 2

11 years ago
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 3

11 years ago
Comment on attachment 213361 [details] [diff] [review]
Fix

Since bug 328249 was checked into the branch, we need this too.
Attachment #213361 - Flags: approval1.8.0.2?
Attachment #213361 - Flags: approval-branch-1.8.1?(brendan)
Comment on attachment 213361 [details] [diff] [review]
Fix

This is a followup fix to the 1.8.0 branch, safe for 1.8.0.2 if that's still taking fixes.

/be
Attachment #213361 - Flags: approval-branch-1.8.1?(brendan) → approval-branch-1.8.1+
Comment on attachment 213361 [details] [diff] [review]
Fix

approved for 1.8.0 branch, a=dveditz
Attachment #213361 - Flags: approval1.8.0.2? → approval1.8.0.2+
(Assignee)

Comment 6

11 years ago
Fix checked into the 1.8 branches.
Keywords: fixed1.8.0.2, fixed1.8.1
please provide testcase or test guidance for this fix.
Whiteboard: [patch] → [patch][tcn-dl]
(Assignee)

Comment 8

11 years ago
The testcase in js/tests/e4x/Expressions/11.6.1.js covers this.

Comment 9

11 years ago
practically every test failed with this bug. I did not see any crashes in my nightly build testing and am running debug build testing now. I will verify it when I complete.

Updated

11 years ago
Whiteboard: [patch][tcn-dl] → [patch][rft-dl]

Comment 10

11 years ago
no longer see the failures which resulted from this bug.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Keywords: fixed1.8.0.2, fixed1.8.1 → verified1.8.0.2, verified1.8.1
You need to log in before you can comment on or make changes to this bug.