Local (in-app-bundle) XULRunner framework finding broken

RESOLVED FIXED

Status

Core Graveyard
Embedding: GRE Core
RESOLVED FIXED
11 years ago
11 months ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

({fixed1.8.0.2, fixed1.8.1})

Trunk
PowerPC
Mac OS X
fixed1.8.0.2, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nvn-dl])

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
The code which finds the XULRunner framework in an app bundle is broken: it strips off a path component it shouldn't.
(Assignee)

Comment 1

11 years ago
Created attachment 213690 [details] [diff] [review]
Don't cut off "libxpcom.dylib", rev. 1
Attachment #213690 - Flags: review?(darin)
Attachment #213690 - Flags: approval-branch-1.8.1?(darin)

Updated

11 years ago
Attachment #213690 - Flags: review?(darin)
Attachment #213690 - Flags: review+
Attachment #213690 - Flags: approval-branch-1.8.1?(darin)
Attachment #213690 - Flags: approval-branch-1.8.1+
(Assignee)

Comment 2

11 years ago
Comment on attachment 213690 [details] [diff] [review]
Don't cut off "libxpcom.dylib", rev. 1

I'd like this for xulrunner 1.8.0.2 to fix a documented packaging strategy, it is no-risk for ffox/tbird since they don't use this codepath.
Attachment #213690 - Flags: approval1.8.0.3?
Attachment #213690 - Flags: approval1.8.0.2?
(Assignee)

Comment 3

11 years ago
Fixed on trunk and 1.8 branch.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED

Comment 4

11 years ago
Comment on attachment 213690 [details] [diff] [review]
Don't cut off "libxpcom.dylib", rev. 1

a=timr
Attachment #213690 - Flags: approval1.8.0.3?
Attachment #213690 - Flags: approval1.8.0.2?
Attachment #213690 - Flags: approval1.8.0.2+
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.2

Updated

11 years ago
Whiteboard: [nvn-dl]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.