329022 - Remove group_name_to_id in favor of creating Group objects

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

This came from a comment on bug 328435 -- we should just eliminate the group_name_to_id function and use Group objects instead.

Comment 1

[Frédéric Buclin]

and the sooner the better. I hate hacks.

Comment 2

[Rémi Zara]

Attachment: patch v1

Remove group_name_to_id

Comment 3

[Frédéric Buclin]

Here is what I found about using the new Bugzilla::Foo($bar)->id() notation:

http://www.unix.org.ua/orelly/perl/advprog/ch07_02.htm

Read the last two sentences of section "7.2.5.1 Detour: The indirect notation":

While the indirect notation has the same effect as the arrow notation, it cannot be used in a chain of calls. The following is possible only with the arrow notation:

use FileHandle;
$fh = FileHandle->new("> foo.txt")->autoflush(1); # Chain of calls


So it seems that you should write Bugzilla::Foo->new($bar)->id(). Could you please update your patch using the arrow notation?

Comment 4

[Rémi Zara]

Attachment: patch v1.1

use "Bugzilla::Group->new({name => 'admin'})->id()" instead of "new Bugzilla::Group({name => 'admin'})->id()"

Comment 5

[Frédéric Buclin]

Comment on attachment 214847 [details] [diff] [review]
patch v1.1

r=LpSolit

Comment 6

[Frédéric Buclin]

Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.68; previous revision: 1.67
done
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.116; previous revision: 1.115
done
Checking in Bugzilla/Group.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v  <--  Group.pm
new revision: 1.12; previous revision: 1.11
done