Closed
Bug 329039
Opened 19 years ago
Closed 19 years ago
make nsIOService's ctor and dtor private
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: Biesinger, Assigned: Biesinger)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.62 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
darin.moz
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
No point in having them public.
|
Assignee | |
Comment 1•19 years ago
|
||
this makes the compiler ensure that there can only be one instance of the io service.
Attachment #213683 -
Flags: superreview?
Attachment #213683 -
Flags: review?(darin)
Attachment #213683 -
Flags: approval-branch-1.8.1?(darin)
|
||
Updated•19 years ago
|
Attachment #213683 -
Flags: superreview?
Attachment #213683 -
Flags: superreview+
Attachment #213683 -
Flags: review?(darin)
Attachment #213683 -
Flags: review+
Attachment #213683 -
Flags: approval-branch-1.8.1?(darin)
Attachment #213683 -
Flags: approval-branch-1.8.1+
|
|
||
Comment 2•19 years ago
|
||
Actually, if the ctor/dtor are private, then having protected sections doesn't make any sense either. You might therefore want to make the protected sections private as well.
|
|
Assignee | |
Comment 3•19 years ago
|
||
fixed, with private.
HEAD:
Checking in netwerk/base/src/nsIOService.h;
/cvsroot/mozilla/netwerk/base/src/nsIOService.h,v <-- nsIOService.h
new revision: 1.58; previous revision: 1.57
done
MOZILLA_1_8_BRANCH:
Checking in netwerk/base/src/nsIOService.h;
/cvsroot/mozilla/netwerk/base/src/nsIOService.h,v <-- nsIOService.h
new revision: 1.55.2.3; previous revision: 1.55.2.2
done
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•