329165 - nsHttpChannel.cpp:127: warning: array subscript has type �char�

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Darin Fisher]

Comment on attachment 213811 [details] [diff] [review]
patch

r+sr+a=darin

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

HEAD:
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  nsHttpChannel.cpp
new revision: 1.276; previous revision: 1.275
done

MOZILLA_1_8_BRANCH:
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  nsHttpChannel.cpp
new revision: 1.256.2.10; previous revision: 1.256.2.9
done

Comment 4

[Ben Fowler]

There are also three in extensions/universalchardet/, e.g.
     JpCntx.cpp:164: warning: array subscript has type 'char'

Do you want a patch (and what is the proper way to report warnings such
as these, I doubt that tagging onto the end of FIXED bug is right)?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #4)
> Do you want a patch (and what is the proper way to report warnings such
> as these, I doubt that tagging onto the end of FIXED bug is right)?

The proper way is to file a bug. Tagging them onto a fixed bug might be ok if that bug introduced them. But, for things that are just a warning and probably not a real bug, that probably only makes sense if you provide a patch too.