Closed Bug 329165 Opened 15 years ago Closed 15 years ago

nsHttpChannel.cpp:127: warning: array subscript has type �char�

Categories

(Core :: Networking, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Attached patch patchSplinter Review
Attachment #213811 - Flags: superreview?(darin)
Attachment #213811 - Flags: review?(darin)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9alpha
Comment on attachment 213811 [details] [diff] [review]
patch

r+sr+a=darin
Attachment #213811 - Flags: superreview?(darin)
Attachment #213811 - Flags: superreview+
Attachment #213811 - Flags: review?(darin)
Attachment #213811 - Flags: review+
Attachment #213811 - Flags: approval-branch-1.8.1+
HEAD:
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  nsHttpChannel.cpp
new revision: 1.276; previous revision: 1.275
done

MOZILLA_1_8_BRANCH:
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v  <--  nsHttpChannel.cpp
new revision: 1.256.2.10; previous revision: 1.256.2.9
done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Summary: nsHttpChannel.cpp:127: warning: array subscript has type ‘char’ → nsHttpChannel.cpp:127: warning: array subscript has type �char�
There are also three in extensions/universalchardet/, e.g.
     JpCntx.cpp:164: warning: array subscript has type 'char'

Do you want a patch (and what is the proper way to report warnings such
as these, I doubt that tagging onto the end of FIXED bug is right)?
(In reply to comment #4)
> Do you want a patch (and what is the proper way to report warnings such
> as these, I doubt that tagging onto the end of FIXED bug is right)?

The proper way is to file a bug. Tagging them onto a fixed bug might be ok if that bug introduced them. But, for things that are just a warning and probably not a real bug, that probably only makes sense if you provide a patch too.
You need to log in before you can comment on or make changes to this bug.