upload control doesn't properly handle relevant and readonly MIPs

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
12 years ago
a year ago

People

(Reporter: aaronr, Assigned: aaronr)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.73 KB, application/xhtml+xml
Details
(Assignee)

Description

12 years ago
good starter bug

If it is supposed to be readonly, upload control doesn't initialize to readonly.  However, it will properly handle readonly after it is refreshed by user interaction.

Upload doesn't handle relevancy at all.

I'm guessing that it has to do with how it sets the intrinsic states during nsXFormsUploadElement::refresh.  It never takes into account the other intrinsic states.
(Assignee)

Comment 1

12 years ago
Created attachment 214041 [details]
testcase

Comment 2

12 years ago
I was sure I filed a bug for this one... surkov also hit that not too long ago.
(In reply to comment #0)
> I'm guessing that it has to do with how it sets the intrinsic states during
> nsXFormsUploadElement::refresh.  It never takes into account the other
> intrinsic states.

Yes, it just sets enabled/disabled, and ignores everything else. Can be fixed as part of bug 313313.
(Assignee)

Comment 3

12 years ago
Might as well do a quick fix to make sure it is ready for 0.5.  Don't know if bug 313313 will be done by 0.5.  Reassigning to sspeiche.
Assignee: aaronr → sspeiche
(Assignee)

Updated

12 years ago
Whiteboard: [good first bug]

Updated

12 years ago
Depends on: 313118

Comment 4

12 years ago
With the mAppearDisabled from bug 313118, this should hopefully be fairly easy to fix. Fixing bug 313313 meanwhile might be easiest, but I'm not sure.
(Assignee)

Comment 5

11 years ago
I started working on bug 313313, so I'll fix this one while I am in there.
Assignee: sspeiche → aaronr
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 6

11 years ago
made a small error in my patch for bug 313313.  Corrected error as part of patch for bug 331984, which should fix this bug, too.
(Assignee)

Updated

11 years ago
Depends on: 331984

Updated

11 years ago
Blocks: 334603

Comment 7

11 years ago
(In reply to comment #6)
> made a small error in my patch for bug 313313.  Corrected error as part of
> patch for bug 331984, which should fix this bug, too.
> 

Testcase works fine. So I guess too bug is fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.