329376 - upload control doesn't properly handle relevant and readonly MIPs

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

good starter bug

If it is supposed to be readonly, upload control doesn't initialize to readonly.  However, it will properly handle readonly after it is refreshed by user interaction.

Upload doesn't handle relevancy at all.

I'm guessing that it has to do with how it sets the intrinsic states during nsXFormsUploadElement::refresh.  It never takes into account the other intrinsic states.

Comment 1

[aaronr]

Attachment: testcase

Comment 2

[Allan Beaufour]

I was sure I filed a bug for this one... surkov also hit that not too long ago.
(In reply to comment #0)
> I'm guessing that it has to do with how it sets the intrinsic states during
> nsXFormsUploadElement::refresh.  It never takes into account the other
> intrinsic states.

Yes, it just sets enabled/disabled, and ignores everything else. Can be fixed as part of bug 313313.

Comment 3

[aaronr]

Might as well do a quick fix to make sure it is ready for 0.5.  Don't know if bug 313313 will be done by 0.5.  Reassigning to sspeiche.

Comment 4

[Allan Beaufour]

With the mAppearDisabled from bug 313118, this should hopefully be fairly easy to fix. Fixing bug 313313 meanwhile might be easiest, but I'm not sure.

Comment 5

[aaronr]

I started working on bug 313313, so I'll fix this one while I am in there.

Comment 6

[aaronr]

made a small error in my patch for bug 313313.  Corrected error as part of patch for bug 331984, which should fix this bug, too.

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #6)
> made a small error in my patch for bug 313313.  Corrected error as part of
> patch for bug 331984, which should fix this bug, too.
> 

Testcase works fine. So I guess too bug is fixed.