329414 - Confirm, ConfirmEx, make it clear what the cancel button should be.

Status: RESOLVED DUPLICATE of bug 345067

(Core Graveyard :: Embedding: APIs, defect)

Description

[Dorian]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060115 K-Meleon/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060115 K-Meleon/1.0

For the generic ConfirmEx dialog, in commonDialog.xul/commonDialog.js, the second button is always set to be the button used if the user discard the dialog by clicking the X.
http://lxr.mozilla.org/mozilla1.8/source/xpfe/global/resources/content/commonDialog.js#162


But, for the wallet component, the cancel button for a ConfirmEx dialog is the initial value of buttonPressed.

See comments:
http://lxr.mozilla.org/mozilla1.8/source/extensions/wallet/src/wallet.cpp#499
http://lxr.mozilla.org/mozilla1.8/source/extensions/wallet/src/wallet.cpp#521

<quote>
PRInt32 buttonPressed = 1; /* default of NO if user exits dialog by clickin X */
</quote>

Other component doesn't initialize this value.
For exemple:
http://lxr.mozilla.org/mozilla1.8/source/security/manager/boot/src/nsSecurityWarningDialogs.cpp#285


The same issue apply to Confirm.



Reproducible: Always

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

confirmex always returns 1 at the moment. It wont work until bug 329414 is fixed.

Depends or Dupe?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lets mark it as a dupe of bug 345067. If it won't be fixed with a patch on bug 345067 we could reopen it again.