329634 - No apparent way to Reload Live Bookmark (or update livemarks)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Tracy Walker [:tracy]]

Seen on Firefox trunk builds from 2006-03-07

-Context click on a Live Bookmark (in BTB or Places)

Tested results:
no option to Reload Live Bookmark is present.
I also don't see any other apparent way to reload a feed

Expected result:
Live Bookmark context click menu should present "Reload Live Bookmark' just above "Sort By Name"

Comment 1

[Hixie (not reading bugmail)]

Reality check. Not a smoketest blocker. Downgrading to "major".

Comment 2

[Tracy Walker [:tracy]]

Ian, are you saying that feed reload shouldn't be a smoketest?

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Maybe once we're not rebuilding the system from the ground up ;-) 

We know about this and will fix it, but it's on the a2 radar. 

Comment 4

[Tracy Walker [:tracy]]

ben, yeah, I'll back off on hammering at Places until it grows beyond sappling.  

Comment 5

[Phil Ringnalda (:philor)]

*** Bug 331358 has been marked as a duplicate of this bug. ***

Comment 6

[Joe Hughes]

(Adding some keywords to the title for better searchability, since I didn't find it before adding a dup.)

Comment 7

[Pam Greene]

"Reload" is now present, but disabled.  Working on a fix and implementation.

Comment 8

[Pam Greene]

Attachment: Implements livemark reloading and enables command properly

- Reorganized function to enable livemark reload menu item
- Pulled nodeIsLivemarkContainer out into its own function for general use
- Implemented livemark reloading menus

Comment 9

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 216657 [details] [diff] [review]
Implements livemark reloading and enables command properly

sr=[e-mail]

Comment 10

[Darin Fisher]

fixed-on-trunk, fixed1.8.1

Comment 11

[Darin Fisher]

Attachment: v1.1 patch - version checked in

This is what I checked in.  It includes a few additional changes:

 * handle merge conflicts in toolbar.xml
 * make similar changes in menu.xml (which were not needed previously)
 * bump UUID for nsILivemarksService since it has shipped in Bon Echo Alpha 1

Comment 12

[Pam Greene]

Attachment: FolderIDs should be PRInt64, not PRInt32

Comment 13

[Darin Fisher]

Comment on attachment 217102 [details] [diff] [review]
FolderIDs should be PRInt64, not PRInt32

r=darin

Comment 14

[Darin Fisher]

attachment 217102 [details] [diff] [review] is now in on the trunk and 1.8 branch.

Comment 15

[Tracy Walker [:tracy]]

verified fixed with recent Bon Echo builds

Comment 16

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv