Bill, it looks like the "Bookmark this Page" context menu option is enabled, even if the URL in question has already been bookmarked. It would be great if this was a bit smarter... and the option not available if the URL in question is already bookmarked. There is a function on the nsIBookmarksService that you can call: IsBookmarked() [it returns PR_TRUE if a URL is already in the user's bookmarks] before deciding whether to call AddBookmark() or not.
Similar to bug 10198. I'd rather warn than disable - what if you actually want the bookmark in two places? What if you would like to be able to figure out where the bookmark is by clicking the "bookmark this page" option.
I'd suggest that 10198 be marked as a DUP of this bug, as this bug has detailed info on how to check for see if a URL has already been bookmarked.
I'd also like to throw my vote in the direction of Warn, not Disable. Users will not always make the connection with why the item is disabled and may think that it is a bug or that the page can not be bookmarked. Remember that many users have hundreds of bookmarks and don't always remember every one they have bookmarked.
Component: Browser-General → Bookmarks
QA Contact: asa → claudius
*** This bug has been marked as a duplicate of 10198 ***
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.