329643 - Unsafe code in toolbar.xml

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

http://lxr.mozilla.org/seamonkey/source/toolkit/content/widgets/toolbar.xml#280

Code in the DOMMenuBarActive/DOMMenuBarInactive handlers looks unsafe. 

There is a function updateStatusText that relies on a |_statusbar| member to be set by one of the above event handlers before it will work (otherwise it will throw an exception). The event handlers may be the only callers, in which case updateStatusText should be called _updateStatusText. 

The getElementById() call & null check should move into _updateStatusText so that the code is more bullet-proof.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

How about this (suggestion from Hixie)

make toolbar.statusbar take/return an element (status bar element). 

That's a lot cleaner than using an id.