329649 - Use colors in request.cgi to indicate bug severity

Status: NEW

(Bugzilla :: User Interface, enhancement)

Description

[Frédéric Buclin]

Using colors to indicate bug severity will help in triaging reviews too. I will also make some small cleanup.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

I also did some cleanup/small UI improvement:

- I now use only one table (so that all columns look aligned => nicer UI)
- I added labels to the form
- I let you discover what I changed too... ;)

Comment 2

[Frédéric Buclin]

Attachment: patch, v2

This patch is really what I wanted and look nice IMO. But myk doesn't like the use of background colors to indicate either severities or priorities.

I post my patch here because I wrote it. But I won't insist any longer.

Comment 3

[Frédéric Buclin]

Attachment: how it looks like with my previous patch (screenshot)

Comment 4

[Frédéric Buclin]

/me gives up

Comment 5

[Frédéric Buclin]

Comment on attachment 214462 [details] [diff] [review]
patch, v2

/me said I give up

Comment 6

[Colin Ogilvie [:cso]]

Would it not be worht doing what buglist.cgi does to a certain extent, bold red for blockers etc.?

Comment 7

[Frédéric Buclin]

myk doesn't like it, but justdave seems more receptive to this UI. Let's see...

Comment 8

[Frédéric Buclin]

(In reply to comment #6)
> Would it not be worht doing what buglist.cgi does to a certain extent, bold red
> for blockers etc.?
> 

Looks ugly (that's what I did initially), because there are two URLs in this table, one for bugs, and one for attachments. Using background colors is much nicer IMO.

Comment 9

[Frédéric Buclin]

Attachment: patch, v2.1

unbitrotten patch.

Comment 10

[GavinS]

Comment on attachment 214799 [details] [diff] [review]
patch, v2.1

Just to check I understand correctly, a changes Summary:

- Add status search
- Add order search
- center grouping type table title
- add days since in created data column
- prefix priority to bug title when sorting by priority
- prefix severity to bug title when sorting by severity
- color bug title column when sorting by severity
- color date column when sorting by date

Reasons for r-

1) Don't like the (P1-) and (Sev-) prefixes. Probably not needed. But
   I could maybe live with appending them, maybe after a <br>

2) Gap above the 'Group By' and 'Sort By' row should not be there.

3) No (obvious to me) indication of flag status. Needed when searching for 'All' or '+-'

4) bz_bimonth should be better: bz_months?

5) Should apply styles to whole row (in case people want to highlight
   the whole row)

6) I think that CSS validators say you should explictly set foreground
   color and background-color together

7) No newline at end of requests.css

8) Is the license for requests.cgi correct? - it says netscape developed it first?

9) 'center' is a bad css name, isn't it? (in: <div class="center">N/A</div>)

10 bz_month == 21 days???

For Extra Points (while you are changing other stuff :)

- Shouldn't we share the severity css colors with buglist.css somehow?
- Sort by: Bug Id?
- Group by: None
- show count of total requests and count per grouped table (alongside the title for each table)
- Add a view-as-buglist link for each grouped table

Comment 11

[Marc Schumann [:Wurblzap]]

Comment on attachment 214799 [details] [diff] [review]
patch, v2.1

Is colouring really what we want?

I think what we want is some way of ordering the list.

Comment 12

[Frédéric Buclin]

(In reply to comment #11)
> Is colouring really what we want?
> 
> I think what we want is some way of ordering the list.

Marc, don't you like my marvelous screenshot? :) Honestly, I don't want to waste my time on this bug if that's not something we want.

Comment 13

[Marc Schumann [:Wurblzap]]

I like the screenshot and the concept, but I'd rather see this as a skin (or part of a skin).

But don't let my personal opinion get in other's way :)

Comment 14

[Frédéric Buclin]

(In reply to comment #13)
> I like the screenshot and the concept, but I'd rather see this as a skin (or
> part of a skin).

Hum... or a checkbox "use colors for the sort order key" for those who do/don't want to see colors?

Comment 15

[GavinS]

I quite like colors as an easy way to indicate priority or importance, so I'm OK with the colors.

If an approver doesn't like the colors, then we can just remove those few bits from the new CSS, yes?

Comment 16

[Frédéric Buclin]

I don't have time to play with this bug before 3.0

Comment 17

[Frédéric Buclin]

The sort order thing is bug 179522.

Comment 18

[Jay Williamson]

Attachment: same problem

Thanks from siocusussi1984.