329690 - Editcomponents update message should only link to edit components

Status: NEW

(Bugzilla :: Administration, task)

Description

[timeless]

Steps:
* change a component's description to include a link

Actual results:
   Updating Component 'Build' of Product 'Webtools'

   Updated description to: 'Web based tool to help <a
                           href="http://webtools.mozilla.org/build/config.cgi">configure a browser build</a>.'

   Updated Default Assignee to: '[e-mail]'.

And no way to know if the link is correct.

Expected results:
provide a link to http://bugzilla.mozilla.org/describecomponents.cgi?product=Webtools#Build

Comment 1

[victory <[e-mail]>]

Attachment: patch for tip

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 250945 [details] [diff] [review]
patch for tip

I don't think this is the right phrase to use. It makes it sound like component changes might not have really happened.. Especially because it is shown for any change.

Comment 3

[timeless]

Attachment: alternate phrase

Comment 4

[Vlad Dascalu]

Comment on attachment 275340 [details] [diff] [review]
alternate phrase

not ok 67 - (en/default) template/en/default/admin/components/updated.html.tmpl has unfiltered directives:
#   99: comp.name
# --ERROR

#   Failed test '(en/default) template/en/default/admin/components/updated.html.tmpl has unfiltered directives:
#   99: comp.name
# --ERROR'
#   in t/008filter.t at line 131.

Comment 5

[timeless]

Attachment: strict filter

Comment 6

[Vlad Dascalu]

Comment on attachment 275406 [details] [diff] [review]
strict filter

This patch breaks our HTML4 validation (tag "<a href..." is not matched by a closing tag).

Comment 7

[timeless]

Attachment: properly close tag

Comment 8

[Vlad Dascalu]

Comment on attachment 276022 [details] [diff] [review]
properly close tag

In my opinion, the "edit other components" link in the components footer:

-> is the edit/modify interface for the read-only describecomponents.cgi page.

-> gives the ability to review the modification and test the link, as it's properly displayed in the edit/modify components table.

The problem is that the components footer contains already three links, which is too much from an usability perspective in order to make sense what each one of them does:

-> edit component again: this should be removed, we've just done this and the screen doesn't include the modifications for review, just a notification whether we did modify something or not.
-> edit components --this should be kept, it's the "back" link that allows the user to go back to the previous page, and maybe review the modifications made.

-> the edit product link -- this should be removed as well as it adds confusion and it's not worthy for the 1-click that is saves (you can reach that immediately after clicking the 2nd/back link).

So the reporter of this bug can be helped by removing two out of those three links, not by adding a 4th. This would be great as well from an usability point of view.

Adding a 4th link to a read-only status page when the middle link provides the edit/modify version of it with the same benefits seems unsuitable per the above considerations.

Sorry for not catching this in the previous reviews.

If we still want this in, we need to remove the "Review" thing from the sentence. Reviewing is done using the 2nd link in the footer; "sharing" could actually be the only reason for linking to the read-only version of listing components page (since an admin views the message).

Comment 9

[timeless]

hrm, yeah. but i can't figure out what admin/components/footer.html.tmpl is doing it's too complicated and doesn't honor its "contract'.

it uses:
no_edit_component_link
no_edit_other_components_link