329727 - Coverity doesn't like ReportError in jscntxt because it pretends reportp could be null

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[timeless]

reportp *can't* be null, as ReportError is a static function and all callers are supposed to pass &report as reportp. But because we null check, coverity gets confused and complains.

Comment 1

[timeless]

Attachment: reduce noise

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 214400 [details] [diff] [review]
reduce noise

>Index: jscntxt.c
> ReportError(JSContext *cx, const char *message, JSErrorReport *reportp)
> {
>+    JS_ASSERT(reportp);

Nit: Move this...

>     /*
>      * Check the error report, and set a JavaScript-catchable exception
>      * if the error is defined to have an associated exception.  If an
>      * exception is thrown, then the JSREPORT_EXCEPTION flag will be set
>      * on the error report, and exception-aware hosts should ignore it.
>      */

...here so you don't have to add  an additonal newline before the major comment.

>-    if (reportp && reportp->errorNumber == JSMSG_UNCAUGHT_EXCEPTION)
>+    if (reportp->errorNumber == JSMSG_UNCAUGHT_EXCEPTION)

r=mrbkap

Comment 3

[timeless]

Comment on attachment 214400 [details] [diff] [review]
reduce noise

mozilla/js/src/jscntxt.c 	3.77