329792 - Remove code for old tag-style folder selector in Bookmark Properties dialog (which needlessly set font size)

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[James Ross]

The properties window for Places sets the font size to 9pt, which totally goes against the point of having standard GUI elements and sizes. I can't even see anything on the dialog that would benefit from a larger-that-I've-set-my-OS-too font size.

Comment 1

[Joe Hughes]

Attachment: Removes the dead code

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 215680 [details] [diff] [review]
Removes the dead code

sr=[e-mail]

Comment 3

[Joe Hughes]

Landed on branch & trunk, see 330023 for landed patch containing this fix.

Comment 4

[Pam Greene]

Part of this, removing portions of the logic in nodeIsRemoteContainer in controller.js, breaks livemark folder display.  See bug 329743.  Is restoring that (and changing its reference to folders to a reference to containers) going to re-break this?

Comment 5

[Joe Hughes]

Pam: I think you're referring to the change in 330023 rather than on this bug?  I took it out because Annie couldn't remember what that logic expressed, and the line:
return asFolder(node).folderType != "";
was giving undefined property errors for folderType.

Now that you've discovered what it's for, feel free to add it back, but make sure that you don't recreate the error.  (It would manifest when you right-click to edit the name of a folder.)  Also, please add comments to make clear what that branch does.

Comment 6

[Pam Greene]

Joe, right, sorry, the patch for bug 330023.  My patch for bug 329743 fixes the folderType errors and expands comments in a couple of places, including the relevant portions of controller.js and the IDL file.  I've verified that folder renaming still works, so I think we're all good.  Thanks!

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv