329796 - Can't debug XForms on Mac OS X

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[jhp (no longer active)]

Bug 309210 made it so debug symbols are stripped from the xforms lib when packaging it in the XPI.  However, it does the stripping for debug builds also, so I can't set breakpoints when trying to debug XForms.

Comment 1

[jhp (no longer active)]

Attachment: patch

Don't strip symbols if MOZ_DEBUG is defined.

Comment 2

[Doron Rosenberg (IBM)]

Comment on attachment 214445 [details] [diff] [review]
patch

not really a build config bug, but a xforms bug :)

Comment 3

[jhp (no longer active)]

Actually, I'm wondering if we shouldn't wrap the rule in rules.mk with "ifndef MOZ_DEBUG", since I don't really see a reason why we would want to strip if we are building debug.  If not, this forces everyone who defines STRIP_XPI to also wrap it with the ifdef.

Comment 4

[Allan Beaufour]

Same goes for Linux.

Comment 5

[jhp (no longer active)]

Attachment: patch v2 - global change

This should be fixed in rules.mk.  It would be foolish to make all users add the MOZ_DEBUG check around STRIP_XPI.

Comment 6

[jhp (no longer active)]

Checked in to trunk. ->FIXED

Comment 7

[jhp (no longer active)]

Comment on attachment 215294 [details] [diff] [review]
patch v2 - global change

Asking for approval for both branches.  Without this patch, we cannot debug XForms XPI on Mac or Linux.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 215294 [details] [diff] [review]
patch v2 - global change

approved for 1.8.0 branch, a=dveditz for drivers

Comment 9

[Daniel Veditz [:dveditz]]

Code freeze for this release is Monday May 1, at which point approval will be withdrawn from this bug if it's not checked in.