The default bug view has changed. See this FAQ.

Can't debug XForms on Mac OS X

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: jhp (no longer active), Assigned: jhp (no longer active))

Tracking

({fixed1.8.0.4, fixed1.8.1})

Trunk
PowerPC
Mac OS X
fixed1.8.0.4, fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
Bug 309210 made it so debug symbols are stripped from the xforms lib when packaging it in the XPI.  However, it does the stripping for debug builds also, so I can't set breakpoints when trying to debug XForms.
(Assignee)

Comment 1

11 years ago
Created attachment 214445 [details] [diff] [review]
patch

Don't strip symbols if MOZ_DEBUG is defined.
Attachment #214445 - Flags: review?(doronr)

Comment 2

11 years ago
Comment on attachment 214445 [details] [diff] [review]
patch

not really a build config bug, but a xforms bug :)
Attachment #214445 - Flags: review?(doronr) → review+
(Assignee)

Comment 3

11 years ago
Actually, I'm wondering if we shouldn't wrap the rule in rules.mk with "ifndef MOZ_DEBUG", since I don't really see a reason why we would want to strip if we are building debug.  If not, this forces everyone who defines STRIP_XPI to also wrap it with the ifdef.

Comment 4

11 years ago
Same goes for Linux.
(Assignee)

Comment 5

11 years ago
Created attachment 215294 [details] [diff] [review]
patch v2 - global change

This should be fixed in rules.mk.  It would be foolish to make all users add the MOZ_DEBUG check around STRIP_XPI.
Attachment #214445 - Attachment is obsolete: true
Attachment #215294 - Flags: review?(benjamin)
Attachment #215294 - Flags: review?(benjamin) → review+
(Assignee)

Comment 6

11 years ago
Checked in to trunk. ->FIXED
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

11 years ago
Comment on attachment 215294 [details] [diff] [review]
patch v2 - global change

Asking for approval for both branches.  Without this patch, we cannot debug XForms XPI on Mac or Linux.
Attachment #215294 - Flags: approval1.8.0.3?
Attachment #215294 - Flags: approval-branch-1.8.1?(benjamin)
Attachment #215294 - Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.1
Comment on attachment 215294 [details] [diff] [review]
patch v2 - global change

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #215294 - Flags: approval1.8.0.3? → approval1.8.0.3+
Code freeze for this release is Monday May 1, at which point approval will be withdrawn from this bug if it's not checked in.
(Assignee)

Updated

11 years ago
Keywords: fixed1.8.0.4
You need to log in before you can comment on or make changes to this bug.