329800 - Agendas today/tomorrow/soon filters end date should exclude 00:00:00 of next day

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stefan Sitter [:ssitter]]

Agendas today/tomorrow/soon filters end date should exclude 00:00:00 of next day

At the moment the end date of the today/tomorrow/soon filter rule includes 00:00:00 of next day. For example the 'Today' filter includes all events that start between 'now' and 'tomorrow 00:00:00'. As the result all-day events and events that start at 00:00:00 are shown in the wrong section.

Steps to Reproduce:
(Depending on your local timezone you need the patch on bug 329647 first.)
1) Create an all-day event or an event that start at 00:00:00 tomorrow.
2) Check the Agenda

Actual Results:
Event is shown in 'Today' section.

Expected Results:
Event is shown in 'Tomorrow' section.

You get similar results if you schedule the event for the day after tomorrow with 'Tomorrow' and 'Soon' section.

Reference:
function refreshPeriodDates() in
http://lxr.mozilla.org/mozilla/source/calendar/lightning/content/agenda-tree.js#383

Comment 1

[Joey Minta]

Attachment: change <= to <

Patch changes the <= comparison to just <, which is the same as == -1.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 214639 [details] [diff] [review]
change <= to <

r=dmose; thanks for the patch!

Comment 3

[Joey Minta]

Patch checked in.