329896 - No broken image icon with broken image without width or height set

Status: RESOLVED WORKSFORME

(Core :: Graphics: ImageLib, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase, I would expect to see a broken image icon there, but I don't see it with current trunk build.
This regressed between 2005-09-18 and 2005-09-19, so likely a regression from bug 11011.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

This was a purposeful change made in bug 11011, per Hixie's alt text spec.

Comment 3

[Martijn Wargers (dead)]

You mean this text, right?
http://www.hixie.ch/specs/alttext
"
There should never be a sized placeholder frame for an image where the
UA does not know the size.

Note that broken images never take up their size as given in HTML, and
if they are unimportant according to the author (i.e., alt='') then
they will in fact not be shown at all (except in legacy/quirks mode).
For these images, a "Page Info" feature is the only way of accessing
the information.
"

But doesn't that contradict with:
"
   For ALL other cases (images not downloaded in 'Don't Load Images'
   mode, broken images, missing images, unrecognised images, and
   images that have no dimensions):

      In CSS terms, make the IMG or INPUT be a non-replaced element.

      If there is any alternative text, or if the document is in
      legacy (or 'quirks') mode and the alt attribute is missing, then
      insert an inline box containing an image icon inside the IMG or
      INPUT element.
"?

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase2

With this testcase, I get a broken image icon to see in current trunk builds.
I don't really see why there should be a difference between the two testcases.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Yesh, those two sections are a little contradictory, or at least the second contradicts the informative text in the first.  Mention it to Ian?

At the moment we just don't implement the second section -- that requires that we show an icon for ALL broken images, including ones with useful alt text, and I'm not sure we want to do that particularly.

I do agree that the rendering difference between testcase and testcase2 is odd; I'll investigate that.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Reopening -- stuart says this is an imagelib bug.  There shouldn't be an imgIContainer if SIZE_AVAILABLE is not set, which is what's happening here.

Comment 7

[Boris Zbarsky [:bzbarsky]]

If it's decided that it's ok to have a non-null imgIContainer here, please reassign back to layout; in that case we'll need to sprinkle flag checks all over our GetImage() callers.

stuart, could you please decide what the imagelib api is supposed to be doing and document in imgIRequest?  That will tell me where we stand with the rest of this stuff.

Comment 8

[Martijn Wargers (dead)]

It seems like the decision is to don't show the broken image icon.
Personally I would have liked the broken image icon to show up. This is also what IE6 is doing. (and for web authors it is easier noticeable when they have some image on a web page screwed up)

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Attachment: IRC Log from #developers

bz asked me to attach this

Comment 10

[Hixie (not reading bugmail)]

None of this is relevant here since the test case in question is in quirks mode and the spec cited above is only relevant to standards mode. In any case, I don't really see the contradiction in the spec, could you point it out more explicitly?
Note that there are already bugs filed on the whole alt text icon thing in standards mode. See bug 41924 comment 179 and bug 180622.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Ah, I see.  The placholder is not inserted for alt=''.  Ok, no contradiction.  ;)
  

Comment 12

[Hixie (not reading bugmail)]

Oh ok.

Comment 13

[Matt Woodrow (:mattwoodrow)]

I see broken image icons for both testcases with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0a2) Gecko/20111129 Firefox/10.0a2

Given that this resolves the original bug description, and that the confusion around specs was for standards mode, not quirks, I'm resolving this as WFM.

Please reopen if this is still an issue.