Firefox will not start if built with places disabled

RESOLVED FIXED

Status

()

--
blocker
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: wgianopoulos, Assigned: wgianopoulos)

Tracking

({fixed1.8.1})

Trunk
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
Since the landing of the patch for bug 329586 it is no longer possible to run a build with places disabled.  Since this patch added a lot of ifdef's and ifndef's for MOZ_PLACES, I am assuming that it was not intended to break non-places builds.

The following error window occurs upon startup.

XML Parsing Error: undefined entity
Location: chrome://browser/content/browser.xul
Line Number 891, Column 17:
                <menuitem id="bookmarkAllCmd"
----------------^
(Assignee)

Updated

13 years ago
Summary: Firefox will not start if built with palces disabled → Firefox will not start if built with places disabled
(Assignee)

Comment 1

13 years ago
Created attachment 214562 [details] [diff] [review]
add the string back to the dtd file.

This resolves the issue, however it might be better to modify the code to use the new string name.
(Assignee)

Updated

13 years ago
Attachment #214562 - Attachment description: add teh string back tot he dtd file. → add the string back to the dtd file.
Comment on attachment 214562 [details] [diff] [review]
add the string back to the dtd file.

r=ben@mozilla.org
Attachment #214562 - Flags: review+
Assignee: nobody → wgianopoulos
Checked in by ben.
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.25.2.8
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.36
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.