330030 - crash (@ nsConverterOutputStream::Flush) if init() did not succeed

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Nickolay_Ponomarev]

Running the following crashes firefox trunk:
var file = Components.classes['@mozilla.org/file/directory_service;1']
                     .getService(Components.interfaces.nsIProperties)
                     .get('ProfD', Components.interfaces.nsIFile);
file.append("test");
var os = Components.classes["@mozilla.org/network/file-output-stream;1"]
                   .createInstance(Components.interfaces.nsIFileOutputStream);
os.init(file, 0x04 | 0x08 | 0x20, 420, 0);
var cos = Components.classes["@mozilla.org/intl/converter-output-stream;1"]
                .createInstance(Components.interfaces.nsIConverterOutputStream);
try {
cos.init(os, "klkl", 0, 0x0000);//throws
} catch(e) {
}
cos.close();//crashes

uconv.dll!nsConverterOutputStream::Flush()  Line 145 + 0x29 bytes	C++
uconv.dll!nsConverterOutputStream::Close()  Line 169 + 0xe bytes	C++
xpcom_core.dll!XPTC_InvokeByIndex(...)      Line 102	C++

Comment 1

[Nickolay_Ponomarev]

Attachment: patch

The destructor part isn't necessary to fix the crash, but Close() is enough there, since it both checks mOutStream and calls Flush().

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 214666 [details] [diff] [review]
patch

oops.

Comment 3

[Darin Fisher]

Comment on attachment 214666 [details] [diff] [review]
patch

In general, it's good if an initialization function leaves the object unchanged when it fails.  While this change doesn't do that, it seems okay.

sr=darin

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in intl/uconv/src/nsConverterOutputStream.cpp;
/cvsroot/mozilla/intl/uconv/src/nsConverterOutputStream.cpp,v  <--  nsConverterOutputStream.cpp
new revision: 1.3; previous revision: 1.2
done

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in on MOZILLA_1_8_BRANCH
Checking in intl/uconv/src/nsConverterOutputStream.cpp;
/cvsroot/mozilla/intl/uconv/src/nsConverterOutputStream.cpp,v  <--  nsConverterOutputStream.cpp
new revision: 1.1.4.2; previous revision: 1.1.4.1
done