Closed
Bug 330102
Opened 19 years ago
Closed 18 years ago
Switch pfs to use principal matching rather than string matching
Categories
(Toolkit Graveyard :: Plugin Finder Service, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha2
People
(Reporter: doronr, Assigned: asaf)
Details
Attachments
(1 file)
|
1.65 KB,
patch
|
Gavin
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Offshot of bug 330037, we need to switch that code to using principals.
|
||
Comment 1•19 years ago
|
||
Too bad you can't do that in JS yet... :( See bug 327244 for what needs to happen for this to work.
Depends on: 327244
|
|
||
Comment 2•18 years ago
|
||
So actually, you can do this all from JS now -- fixing the deps of bug 327244 allowed that.
No longer depends on: 327244
Flags: blocking-firefox3?
|
Assignee | |
Comment 3•18 years ago
|
||
Assignee: doronr → mano
Status: NEW → ASSIGNED
Attachment #246818 -
Flags: superreview?(bzbarsky)
Attachment #246818 -
Flags: review?(gavin.sharp)
|
|
Assignee | |
Updated•18 years ago
|
Target Milestone: --- → Firefox 3 alpha2
|
|
||
Comment 4•18 years ago
|
||
Comment on attachment 246818 [details] [diff] [review]
untested
>Index: toolkit/mozapps/plugins/content/pluginInstallerWizard.js
>+ var pluginPagePrincipal =
>+ window.opener.content.document.documentElement.nodePrincipal;
You can just do window.opener.content.document.nodePrincipal here.
sr=bzbarsky with that.
Attachment #246818 -
Flags: superreview?(bzbarsky) → superreview+
|
||
Updated•18 years ago
|
Attachment #246818 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 5•18 years ago
|
||
mozilla/toolkit/mozapps/plugins/content/pluginInstallerWizard.js 1.19
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•18 years ago
|
Flags: blocking-firefox3?
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
|
|
||
Updated•10 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•