330103 - Hard coded strings l18n

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Cédric Corazza]

I packaged the Lightning xpi (0.1RC1 Linux) in French. Some strings are not localized. I searched in the locale part (calendar-fr-FR.jar and fr-FR.jar) and didn't find anything.
These strings are "Today, Tomorrow and Soon" located in the "Agenda" tab.
The only file I found these strings in is agenda-tree.js so I guess it is guilty :-) .

Comment 1

[Cédric Corazza]

Me again,
I (in fact Frederic, one of the FrenchMozilla translator, tester, ...) found some other non-localizable strings and as discussed on IRC, a single tracking bug is the most suitable way, so :
The title windows for 'New Event' and 'Edit Event' is non-localizable.
I'm not a coder but 'New Event' seems to be hard-coded in calendar-event-dialog.js and 'Edit Event' in calendar-event-dialog.js and/or calendar-management.js.
Voila

Comment 2

[Stefan Sitter [:ssitter]]

"Today", "Tomorrow", "Soon" - agenda categories:
/calendar/lightning/content/agenda-tree.js, line 50 et seq.

"New Event" - default name for new events:
/calendar/lightning/content/calendar-management.js, line 193
/calendar/resources/content/calendarWindow.js, line 60 

"New Event", "Edit Event", "New Task", "Edit Task" - item dialog title:
/calendar/base/content/calendar-event-dialog.js, line 390 et seq.

Comment 3

[Joey Minta]

Attachment: use stringbundles

Patch moves the strings to stringbundles to enable localization.  Also removes a bunch of useless lines from the agenda tree and fixes strict warnings about using sharp variables.  The Sunbird changes block 0.3a2, because that release should be fully localizable.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 215541 [details] [diff] [review]
use stringbundles

r=mvl

Comment 5

[Joey Minta]

Patch checked in.