Create New Calender: more calenders to be created

VERIFIED FIXED

Status

VERIFIED FIXED
13 years ago
12 years ago

People

(Reporter: solarisciel, Assigned: robin.edrenius)

Tracking

Sunbird 0.3a1
x86
Windows XP

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060310 Mozilla Sunbird/0.3a1+

When I create a new calender, I forgot to set "color" to it and clicked NEXT.
Oops! I clicked BACK. Fixed color and go next again.
Something is strange. There are 2 calenders with same name! They are not needed.


Reproducible: Always

Steps to Reproduce:
1. Start "Create New Calender" Wizard
2. Click "NEXT"
3. Then click "BACK"
4. Change Settings and click "NEXT" again
5. Click "Finish"
Actual Results:  
There are 2 calenders created!

Expected Results:  
Only One calender must be created.
(Reporter)

Comment 1

13 years ago
Oh? why Firefox user-agent shown? I pasted sunbird one.
Version: unspecified → Sunbird 0.3a1
(Assignee)

Comment 2

13 years ago
Confirming.

We should change so that the calendar isn't created before finish is pressed.

(The text in the last window would have to be changed as well, to something like "Press finish to create the calendar")
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Comment 3

13 years ago
Assigning to myself.
Assignee: nobody → robin.edrenius
(Assignee)

Comment 4

13 years ago
Created attachment 214773 [details] [diff] [review]
Patch v1

This patch changes when doCreateCalendar() is called. With this patch it's called when finish is pressed in the last page instead of when next is pressed in the page before.

Two l10n strings had to be changed as well.
Attachment #214773 - Flags: first-review?(jminta)

Comment 5

13 years ago
Comment on attachment 214773 [details] [diff] [review]
Patch v1

mvl is a better person for this review.
Attachment #214773 - Flags: first-review?(jminta) → first-review?(mvl)
Comment on attachment 214773 [details] [diff] [review]
Patch v1

No, this is the wrong solution. There should be page to indicate success or failure after creating a calendar. Creating a calendar can fail.
So the thing to do would be to disable 'back' when on the last page. And then we should actually test if creating the calendar succeeded.
Attachment #214773 - Flags: first-review?(mvl) → first-review-
(Assignee)

Comment 7

13 years ago
Created attachment 214915 [details] [diff] [review]
Disable backbutton on last page

> So the thing to do would be to disable 'back' when on the last page.

This patch disables the backbutton on the last page of the wizard by setting canRewind to false.
Attachment #214773 - Attachment is obsolete: true
Attachment #214915 - Flags: first-review?(mvl)
Comment on attachment 214915 [details] [diff] [review]
Disable backbutton on last page

r=mvl
Attachment #214915 - Flags: first-review?(mvl) → first-review+
patch checked in
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 10

12 years ago
verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060929 Sunbird/0.3
Status: RESOLVED → VERIFIED
Whiteboard: [litmus testcase wanted]

Comment 11

12 years ago
Litmus testcase 2609 created
Whiteboard: [litmus testcase wanted]
You need to log in before you can comment on or make changes to this bug.