330142 - Building of minimo by Mozilla_Build_FAQ failed

Status: RESOLVED FIXED

(Minimo Graveyard :: Build Config, defect)

Description

[Oleg Romashin (:romaxa)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1)

Building Minimo browser, using simple instuctions from 
http://developer.mozilla.org/en/docs/Mozilla_Build_FAQ
failed.


Reproducible: Always

Steps to Reproduce:
1. cvs -z3 -d :pserver:[e-mail]:/cvsroot co mozilla/client.mk
2. cp mozilla/minimo/config/mozconfig/linux_x86 mozilla/mozconfig
3. make -f client.mk checkout
autoconf && ./configure && make


Actual Results:  
Building failed with message:
make[5]: Leaving directory `/home/work/mozilla_new/mozilla/intl/uconv/native'
make[5]: Entering directory `/home/work/mozilla_new/mozilla/intl/uconv/src'
make[5]: *** No rule to make target `../ucvnative/libucnative_s.a', needed by `libuconv.a'.  Stop.


Expected Results:  
Building finished

I have found 2 solution for this problem:
1)
--- mozilla/configure.in.orig   2006-03-11 11:59:14.000000000 +0200
+++ mozilla/configure.in        2006-03-11 11:57:40.000000000 +0200
@@ -4405,7 +4405,7 @@
   MOZ_SVG=
   MOZ_UNIVERSALCHARDET=
   MOZ_UPDATER=
-  MOZ_USE_NATIVE_UCONV=1
+  MOZ_USE_NATIVE_UCONV=
   MOZ_V1_STRING_ABI=
   MOZ_VIEW_SOURCE=
   MOZ_XPFE_COMPONENTS=

2)

1. echo "ac_add_options --disable-native-uconv" >> mozilla/minimo/config/mozconfig/linux_x86
2. cp mozilla/minimo/config/mozconfig/linux_x86 mozilla/mozconfig

Comment 1

[Doug Turner (:dougt)]

this is a bandaide.  on linux we really should use native uconv.

Can you see why the libary names are different?

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: BUGFIX: wrong reference at old directory. intl/ucinv/ucnative

BUGFIX:

Has been fixed wrong directory in Makefile.

Comment 3

[Oleg Romashin (:romaxa)]

(In reply to comment #2)
> Created an attachment (id=215002) [edit]
> BUGFIX
> 
> BUGFIX:
> 
> Has been fixed wrong directory in Makefile.
> 

it is the third, and I think correct solution ;)

Comment 4

[Benjamin Smedberg]

Comment on attachment 215002 [details] [diff] [review]
BUGFIX:
wrong reference at old directory. intl/ucinv/ucnative

It would help Doug and I if you marked the review?[e-mail] or review?[e-mail] flag on these patches (it would also be good to name the attachment something more descriptive than BUGFIX so that we know what it is when we're looking at our review queue).

Comment 5

[Oleg Romashin (:romaxa)]

Comment on attachment 215002 [details] [diff] [review]
BUGFIX:
wrong reference at old directory. intl/ucinv/ucnative

intl/uconv directory don't contain "ucnative" folder anymore (instead it - "native"), but Makefile.in in  has reference on old directory name

Comment 6

[Antonio Gomes (tonikitoo)]

was this patch check in Doug or Benjamin ?

Romaxa, shouldn't it be marked as duplicated of 213325 or vice-versa ?

Comment 7

[Antonio Gomes (tonikitoo)]

(In reply to comment #6)
> was this patch check in Doug or Benjamin ?
> 
> Romaxa, shouldn't it be marked as duplicated of 213325 or vice-versa ?
> 

ops, not 213325 but 328736 ! Sorry

Comment 8

[Doug Turner (:dougt)]

Checking in Makefile.in;
/cvsroot/mozilla/intl/uconv/src/Makefile.in,v  <--  Makefile.in
new revision: 1.86; previous revision: 1.85
done

fixed on trunk.  the branch does NOT have this problem.

marking fixed.  

Comment 9

[Doug Turner (:dougt)]

*** Bug 328736 has been marked as a duplicate of this bug. ***