Closed
Bug 330190
Opened 18 years ago
Closed 18 years ago
Change widgets to use initEvent(..., true, true); for backwards compatibility
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Unassigned)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
22.01 KB,
patch
|
bryner
:
review+
smaug
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
18.78 KB,
patch
|
Details | Diff | Splinter Review |
Prior to bug 234455 events always bubbled through XUL elements. We should maintain compatibility by fixing all our calls to initEvent.
Reporter | ||
Comment 1•18 years ago
|
||
This includes backouts of the tabbrowser.xml changes from bug 234455.
Attachment #214795 -
Flags: superreview?(jag)
Attachment #214795 -
Flags: review?(mconnor)
Reporter | ||
Comment 2•18 years ago
|
||
Comment on attachment 214795 [details] [diff] [review] Proposed patch Just checking that what I've done for radio.xml matches the new event system.
Attachment #214795 -
Flags: review?(smaug)
Comment 3•18 years ago
|
||
Comment on attachment 214795 [details] [diff] [review] Proposed patch Looks right to me. So you are backing out my changes to tabbrowser.xmls because you fix events to bubble. Radio.xmls look right too, there the 'select' event is created using .initEvent("select", false, true) so no need to call .preventBubble(). Thanks for doing this!
Attachment #214795 -
Flags: review?(smaug) → review+
Comment 4•18 years ago
|
||
(I wonder one thing... why initEvent("evenName", false, true) has been used so often...)
Comment 5•18 years ago
|
||
Comment on attachment 214795 [details] [diff] [review] Proposed patch Smaug: I suspect it's a simple matter of copy&paste :-) sr= on the xpfe changes
Attachment #214795 -
Flags: superreview?(jag) → superreview+
Comment 6•18 years ago
|
||
I tried this patch and installed multizilla, it worked a dream. Without this patch only the first tab on multizilla is connected to the url bar although new tabs appear and will open a new page if you right click links and select open in new tab. New tabs are not connected to the url bar. Any url entered opens in the first tab.
Comment 7•18 years ago
|
||
Comment on attachment 214795 [details] [diff] [review] Proposed patch r=me on the toolkit patch if you'd like.
Attachment #214795 -
Flags: review?(mconnor) → review+
Reporter | ||
Comment 8•18 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 9•18 years ago
|
||
Minus the tabbrowser and
Attachment #215016 -
Flags: approval-branch-1.8.1?(neil)
Comment 10•18 years ago
|
||
(In reply to comment #9) > Created an attachment (id=215016) [edit] > Minus the tabbrowser and ... radio.xml changes. As I understand it, the parameter has no effect on the branch, so this patch essentially does nothing but keep things in sync.
Reporter | ||
Updated•18 years ago
|
Attachment #215016 -
Flags: approval-branch-1.8.1?(neil) → approval-branch-1.8.1+
Comment 11•18 years ago
|
||
This includes all the initEvent changes from this bug, plus the initEvent changes from attachment 214345 [details] [diff] [review] of bug 234455 (to colorpicker.xml).
Attachment #215016 -
Attachment is obsolete: true
Attachment #215017 -
Flags: approval-branch-1.8.1?
Updated•18 years ago
|
Attachment #215017 -
Flags: approval-branch-1.8.1?
Comment 12•18 years ago
|
||
Comment on attachment 215017 [details] [diff] [review] fixed branch patch [checked in] Checked in on the 1.8 branch, 2006-03-14 09:05.
Attachment #215017 -
Attachment description: fixed branch patch → fixed branch patch [checked in]
Updated•4 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•