330216 - [Mac] "reference to undefined property contentNode.id" opening toolbar bookmark folder

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Phil Ringnalda (:philor)]

Opening a bookmark folder iterates up through its parent nodes to see if it's a child of the bookmarks menu, but that warns when it hits the anonymous nodes in the bookmarks toolbar.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix

Comment 2

[Annie Sullivan]

Do you need me to check this in for you?

Comment 3

[Phil Ringnalda (:philor)]

Yes, please.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Don't all nodes have .id?

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 214817 [details] [diff] [review]
Fix

Nope, two things without an .id in the chain: the one I was expecting, the toolbarbutton for the bookmark folder, and the #document that's the ultimate parent.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 214817 [details] [diff] [review]
Fix

sr=[e-mail]

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv