330263 - Off-by-one error in Places drag and drop

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[PikeUK]

Comment 1

[PikeUK]

Oops!

Anyway, if you try to drag a bookmark to a position below its current place it will move down one too far, it seems like its counting itself when it shouldn't.

Steps to Reproduce:
1. Open Bookmarks->Organize Bookmarks.
2. In the Places window find a bookmarks folder that has at least 3-4 entries.
3. Drag the top bookmark below the second bookmark.

Actual Results:
The dragged bookmark ends up as the third one down.

Expected Results:
The dragged bookmark should end up as the second one down.

Comment 2

[PikeUK]

Confirming my own bug (sorry, the unguided new bug form is my nemesis).

Comment 3

[Ria Klaassen (not reading all bugmail)]

I see the same in the bookmarks-menu and bookmarks toolbar folder and all sub-folders; not only in the Places view.
It only goes wrong when you drag downwards, not upwards.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Changes the d&d code to locate a node within a folder by using the current result, not a new one. (walk the hierarchy of the current tree, rather than executing a new query by calling getFolderContents)

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

fixed branch and trunk

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv