Closed Bug 330290 Opened 18 years ago Closed 18 years ago

Edit users should include user's real name and address in title

Categories

(Bugzilla :: Administration, task)

Product:
Bugzilla
Component:
Administration
Version:
2.20.1
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.0

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(1 file, 2 obsolete files)

blah
791 bytes, patch
LpSolit
: review+
Details | Diff | Splinter Review 
I just opened 10 users in tabs (it could have been windows), each title is "Edit User", I have no clue which one's which, it's absolutely useless.
Attached patch first attempt (obsolete) — — Splinter Review 

        Attachment #214919 -
        Flags: review?(LpSolit)

    
  
OS: MacOS X → All
Hardware: Macintosh → All

    
  
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 214919 [details] [diff] [review]
first attempt

r=wurblzap by inspection.

        Attachment #214919 -
        Flags: review?(LpSolit) → review+

    
  
Flags: approval?
Flags: approval2.22?
Flags: approval2.20?
Target Milestone: --- → Bugzilla 2.20

    
    

    
  
Could we stop taking UI changes on the 2.20 branch? I'm strongly against taking this patch for 2.20. The main reason is that some users have already customised their 2.20 installation and may now conflict due to this patch. This also affects people who have translated their 2.20 installation.

    
    

    
  
Comment on attachment 214919 [details] [diff] [review]
first attempt

>+[% IF otheruser.name %]
>+  [% user_label="$otheruser.name ($otheruser.login)" %]
>+[% ELSE %]
>+  [% user_label = otheruser.login %]
>+[% END %]

we have $user->identity for that.

        Attachment #214919 -
        Flags: review-

    
  
Flags: approval?
Flags: approval2.22?
Flags: approval2.20?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        identity ... (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #214919 -
        Attachment is obsolete: true

        Attachment #214986 -
        Flags: review?(LpSolit)

    
  
Depends on: 330555

    
  
Target Milestone: Bugzilla 2.20 → Bugzilla 2.22

    
    

    
  
Comment on attachment 214986 [details] [diff] [review]
identity ...

> [% PROCESS global/header.html.tmpl
>-  title = "Edit user $login"
>+  title = "Edit user $otheruser.identity"

You have to escape it due to bug 330555. Or wait till this bug is fixed.

        Attachment #214986 -
        Flags: review?(LpSolit) → review-

    
    

    
  
Hurry up if you want this fix for 3.0. We freeze in 2 weeks.
Target Milestone: Bugzilla 2.22 → Bugzilla 3.0

    
    

    
  

      
      
      
      

        Attached patch
          
          
        blah
        — 
          — Splinter Review
      

    


  

        Attachment #214986 -
        Attachment is obsolete: true

        Attachment #242783 -
        Flags: review?(LpSolit)

    
    

    
  
Comment on attachment 242783 [details] [diff] [review]
blah

Works fine. The filtering is now correct. r=LpSolit

        Attachment #242783 -
        Flags: review?(LpSolit) → review+

    
  
Flags: approval?
Flags: approval? → approval+

    
    

    
  
Checking in template/en/default/admin/users/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.8; previous revision: 1.7
done

Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: