Closed
Bug 330290
Opened 19 years ago
Closed 18 years ago
Edit users should include user's real name and address in title
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(1 file, 2 obsolete files)
791 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
I just opened 10 users in tabs (it could have been windows), each title is "Edit User", I have no clue which one's which, it's absolutely useless.
Attachment #214919 -
Flags: review?(LpSolit)
Updated•19 years ago
|
OS: MacOS X → All
Hardware: Macintosh → All
Updated•19 years ago
|
Status: NEW → ASSIGNED
Comment 2•19 years ago
|
||
Comment on attachment 214919 [details] [diff] [review]
first attempt
r=wurblzap by inspection.
Attachment #214919 -
Flags: review?(LpSolit) → review+
Updated•19 years ago
|
Target Milestone: --- → Bugzilla 2.20
![]() |
||
Comment 3•19 years ago
|
||
Could we stop taking UI changes on the 2.20 branch? I'm strongly against taking this patch for 2.20. The main reason is that some users have already customised their 2.20 installation and may now conflict due to this patch. This also affects people who have translated their 2.20 installation.
![]() |
||
Comment 4•19 years ago
|
||
Comment on attachment 214919 [details] [diff] [review]
first attempt
>+[% IF otheruser.name %]
>+ [% user_label="$otheruser.name ($otheruser.login)" %]
>+[% ELSE %]
>+ [% user_label = otheruser.login %]
>+[% END %]
we have $user->identity for that.
Attachment #214919 -
Flags: review-
![]() |
||
Updated•19 years ago
|
Flags: approval?
Flags: approval2.22?
Flags: approval2.20?
Attachment #214919 -
Attachment is obsolete: true
Attachment #214986 -
Flags: review?(LpSolit)
![]() |
||
Updated•19 years ago
|
Target Milestone: Bugzilla 2.20 → Bugzilla 2.22
![]() |
||
Comment 6•19 years ago
|
||
Comment on attachment 214986 [details] [diff] [review]
identity ...
> [% PROCESS global/header.html.tmpl
>- title = "Edit user $login"
>+ title = "Edit user $otheruser.identity"
You have to escape it due to bug 330555. Or wait till this bug is fixed.
Attachment #214986 -
Flags: review?(LpSolit) → review-
![]() |
||
Comment 7•18 years ago
|
||
Hurry up if you want this fix for 3.0. We freeze in 2 weeks.
Target Milestone: Bugzilla 2.22 → Bugzilla 3.0
Attachment #214986 -
Attachment is obsolete: true
Attachment #242783 -
Flags: review?(LpSolit)
![]() |
||
Comment 9•18 years ago
|
||
Comment on attachment 242783 [details] [diff] [review]
blah
Works fine. The filtering is now correct. r=LpSolit
Attachment #242783 -
Flags: review?(LpSolit) → review+
![]() |
||
Updated•18 years ago
|
Flags: approval?
Updated•18 years ago
|
Flags: approval? → approval+
![]() |
||
Comment 10•18 years ago
|
||
Checking in template/en/default/admin/users/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/edit.html.tmpl,v <-- edit.html.tmpl
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•