330391 - Add tooltips to events in the Agenda / Today Pane

Status: RESOLVED WORKSFORME

(Calendar :: Lightning Only, enhancement)

Description

[Andras Keri]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.1) Gecko/20060111 Firefox/1.5.0.1
Build Identifier: Lightning 0.1 RC2 (build: 2006031011)

When the mouse hovers over an event, a box should pop up showing extra information (location, description, attendees etc.) about the event.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Stefan Sitter [:ssitter]]

That is a good idea. 
I once tried to achieve this using the code that already exists in Sunbird; but that was not as easy as I thought. First this code needs some cleanup and removing of global vars. The patch in Bug 322768 will help to achive this.

Comment 2

[Joey Minta]

Attachment: remove gcalendarbundle deps and implement

I previously removed dependencies in mouseoverPreviews.js on gCalendarWindow and on dateUtil.js.  This patch removes the final dependency, gCalendarBundle and then makes the necessary changes to actually get these tooltips wired up in the views.  It still remains to get tooltips for the agenda-tree and tasklist, but I think this is a decent start.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 221507 [details] [diff] [review]
remove gcalendarbundle deps and implement

>+  <tooltip id="itemTooltip"
>+           noautohide="true"/>
>+

This doesn't deserve two lines.  Spare the text density, spoil the XUL, or something.

> /** String for event status: (none), Tentative, Confirmed, or Cancelled **/
> function getEventStatusString(calendarEvent)
> {
>+  var sbs = Components.classes["@mozilla.org/intl/stringbundle;1"]
>+                      .getService(Components.interfaces.nsIStringBundleService);
>+  var props = sbs.createBundle("chrome://calendar/locale/calendar.properties");

Everyone together now!

> {
>+  var sbs = Components.classes["@mozilla.org/intl/stringbundle;1"]
>+                      .getService(Components.interfaces.nsIStringBundleService);
>+  var props = sbs.createBundle("chrome://calendar/locale/calendar.properties");

o/~ O how we do love our helpers o/~

>+  var sbs = Components.classes["@mozilla.org/intl/stringbundle;1"]
>+                      .getService(Components.interfaces.nsIStringBundleService);
>+  var props = sbs.createBundle("chrome://calendar/locale/calendar.properties");

o/~ God bless them, every one o/~

r=shaver

Comment 4

[Joey Minta]

patch checked in.  Leaving bug open to add tooltips to the agenda tree.

Comment 5

[Joey Minta]

Re-assigning my bugs to [e-mail] due to recent developments.

Comment 7

[Stefan Sitter [:ssitter]]

Works for me using Lightning 1.0pre (20090304) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090304 Shredder/3.0b3pre.