330420 - Remove unnecessary nsIClassInfo dependencies

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Brian Ryner (not reading)]

Currently, pretty much file in the source base includes nsIClassInfo.h via nsISupportsImpl.h.  We should factor the nsIClassInfo implementation macros out into a new header and remove that dependency, since most consumers don't need it.  My testing shows that with this change, about 2/3 of object files no longer include nsIClassInfo.h via any code path (tested by examining .deps/*.pp files).

While we're at it, nsIClassInfo.idl unnecessarily includes nsIProgrammingLanguage.idl.  Very few consumers need this, really only objects which implement nsIClassInfo themselves.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

Comment 2

[Darin Fisher]

Over IM, I objected to including nsIClassInfoImpl.h from nsIClassInfo.h on the basis of wanting to keep frozen interfaces clean.  Will it just be too painful to include it manually everywhere?

Comment 3

[Brian Ryner (not reading)]

(In reply to comment #2)
> Over IM, I objected to including nsIClassInfoImpl.h from nsIClassInfo.h on the
> basis of wanting to keep frozen interfaces clean.  Will it just be too painful
> to include it manually everywhere?
> 

Oh, I misunderstood what you said.  I thought you were just suggesting that we have the implementation macros factored out into a separate file, rather than inside a %{C++ section of nsIClassInfo.idl.

I can make that change if you'd like, it should be pretty straightforward.

Comment 4

[Brian Ryner (not reading)]

Attachment: patch rev 2

Comment 5

[Darin Fisher]

Comment on attachment 215065 [details] [diff] [review]
patch rev 2

r=darin

Comment 6

[Brian Ryner (not reading)]

checked in