330579 - Invalid bind/xpath doesn't cause xforms-compute-error

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Steve Speicher]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060315 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060315 Firefox/1.6a1

This is part of XForms 1.0 test suite, test case: "3.3.3.a2 submission element has invalid bind attribute". 

I receive an log entry in Console: 
Error: XForms Error (6): Error evaluating nodeset expression: /invalid car/invalid make
Source File: file:///C:/work/eclipse/workspaces/primary-20050928/XForms10_Test_Suite_Work/Mozilla1.0/Chapt3/3.3/3.3.3/3.3.3.a2.xhtml
Line: 0
Source Code:
<xforms:bind id="make_bind" nodeset="/invalid car/invalid make"/>



Reproducible: Always

Steps to Reproduce:
1. Load test case
2. observe Console message
3. observe no modal message for xforms-compute-error



Expected Results:  
Should see modal message (perhaps not console popup)

Comment 1

[Steve Speicher]

Attachment: test case

Comment 2

[Steve Speicher]

Likewise for test case: 4.5.4.a xforms-compute-exception

Appears this event is not being fired.

Comment 3

[Steve Speicher]

Attachment: another sample, from test suite 4.5.4.a

Comment 4

[aaronr]

We do fire this event, but just when evaluating the xpath expressions for the model item properties.

Looks like what we need to do to fix the first one is to check the return code from the evaluation of the nodeset in nsXFormsModelElement::ProcessBind() to see if it is NS_ERROR_DOM_INVALID_EXPRESSION_ERR and if it is, throw the eEvent_ComputeException event.  Otherwise throw the eEvent_BindingException.

For the second testcase, we DO dispatch the compute exception event but since the DOMContentLoaded event hasn't happened yet, the XML event listeners aren't attached at this point so the form author's handler can't handle the event.  This is a known bug, bug 315712

Comment 5

[aaronr]

Attachment: patch

we'll now dispatch a compute exception for bad xpath expression during nodeset evaluation.  Still won't see the popup message due to bug 315712

Comment 6

[aaronr]

checked into trunk