330626 - coreconf/Linux.mk does not detect mips64

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Martin Michlmayr]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1)

When you run a 64-bit Linux kernel on MIPS hardware, the output of "uname -m" is "mips64" rather than "mips".  mozilla/security/coreconf/Linux.mk however only checks for "mips".  "mips64" needs to be added.

Reproducible: Always

Steps to Reproduce:
$ uname -m
mips64

Actual Results:  
The result of this is that x86 will be assumed and this leads to compilation errors later on.

Comment 1

[Martin Michlmayr]

Attachment: Add mip64 detection to mozilla/security/coreconf/Linux.mk

Comment 2

[Mike Hommey [:glandium]]

Martin, isn't an "else" (and the corresponding "endif") missing from your patch ?

Comment 3

[Alexander Sack]

confirmed.

Comment 4

[Martin Michlmayr]

Comment on attachment 215190 [details]
Add mip64 detection to mozilla/security/coreconf/Linux.mk

bogus patch

Comment 5

[Martin Michlmayr]

Attachment: Add mip64 detection to mozilla/security/coreconf/Linux.mk

fixed (and tested) patch

Comment 6

[Martin Michlmayr]

I tested the new patch by compiling mozilla-thunderbird and it works.  mips64 is now recognized as mips.

Comment 7

[Robert Relyea]

Comment on attachment 215296 [details] [diff] [review]
Add mip64 detection to mozilla/security/coreconf/Linux.mk

please merge with patch in bug 330628 first.

bob

Comment 8

[Martin Michlmayr]

Comment on attachment 215296 [details] [diff] [review]
Add mip64 detection to mozilla/security/coreconf/Linux.mk

need to merge patches

Comment 9

[Martin Michlmayr]

Attachment: Add x86 and mip64 detection to mozilla/security/coreconf/Linux.mk

merge patches, as requested

Comment 10

[Robert Relyea]

Comment on attachment 215917 [details] [diff] [review]
Add x86 and mip64 detection to mozilla/security/coreconf/Linux.mk

Thanks,
r+ relyea

Comment 11

[timeless]

perhaps this could be checked in?

Comment 12

[Reed Loden [:reed]]

Yeah, if this is still relevant, can we get this checked-in?

Comment 13

[Nelson Bolyard (seldom reads bugmail)]

Bob, you should have committed this patch when you reviewed it.
Now, it does not apply cleanly because the second half of this patch 
was already committed by someone else for another (newer) bug.
But it's simple enough to get the essential change in here (for mips64).
Please commit the fix.

I believe that, if bugzilla added a reviewer to a bug's CC list when review
is requested of that reviewer, this problem (of bugs falling off the radar) 
would be greatly reduced.

Comment 14

[Serge Gautherie (:sgautherie)]

This needs cvs=1.9.0 checkin rather than
mozilla-central, right?

Comment 15

[Nelson Bolyard (seldom reads bugmail)]

Serge, It needs CVS checkin in the NSS trunk.  After that, it may be 
imported into other downstream repositories in subsequent snapshots.

Comment 16

[Serge Gautherie (:sgautherie)]

Nelson, can you help to get it checked it?
(I don't think I can land NSS patches, can I?)

Comment 17

[Robert Relyea]

Does this still need a checkin?

The current coreconf will accept mips64 and build setting OS_ARCH to mips64.
This patch change that so it accepts mips64, but sets the OS_ARCH to mips

I'm ok with checking in that change, I just want to make sure it's needed.

bob

Comment 18

[Robert Relyea]

Hearing no comment I'm cancelling the review and closing the bug. Please reopen the bug if you need OS_ARCH to read mips instead of miips64 and I'll check in the change.

bob