330641 - calendar widget for xul

Status: RESOLVED FIXED

(Core Graveyard :: XForms, enhancement)

Description

[alexander :surkov (:asurkov)]

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

It's only compact calendar widget for xul. I want to do full calendar in next bug. Comments about style issues are looked forward.

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 217271 [details] [diff] [review]
patch

I want to split the bug on two: "exposing base interface" (bug 332945) and "calendar for xul".

Comment 3

[alexander :surkov (:asurkov)]

Attachment: patch2

Comment 4

[alexander :surkov (:asurkov)]

Attachment: testcase

Comment 5

[Allan Beaufour]

Comment on attachment 222326 [details] [diff] [review]
patch2

I think the behaviour of readonly inputs and outputs are wrong. The UI should
be driven by the instance data. It's ok that the user can navigate RO
calendars, but as soon as focus is lost the control should display the
instance data value. Another bug for that, as XHTML aparently already have
this behaviour too.


> --- mozilla.orig/extensions/xforms/resources/content/widgets-xul.xml	1970-01-01 08:00:00.000000000 +0800

> +      <!-- Return true if node is control element for a day -->
> +      <method name="isDayControl">
> +        <parameter name="aNode"/>
> +        <body>
> +          if (aNode.localName != "toolbarbutton" || aNode.namespaceURI != this.XUL_NS)

nit: split long line

> +      <method name="buildUIInternal">
> +        <body>
> +          <![CDATA[
> +          var dayOfWeekNames = this.getDaysOfWeekNames();
> +
> +          var row = document.createElementNS(this.XUL_NS, "row");
> +
> +          // create days of a week names
> +          var header, description;
> +          for (var i = 0; i < 7; i++) {
> +            description = this.ownerDocument.createElementNS(this.XUL_NS, "description");

nit: split

> --- mozilla.orig/extensions/xforms/resources/skin/widgets-xul.css	1970-01-01 08:00:00.000000000 +0800

> +.toolbarbutton-dn {
> +  list-style-image: url('chrome://global/skin/arrow/arrow-dn.gif');
> +  padding: 0px;
> +  /*padding-left: 3px;
> +  margin-top: -1px;*/

remove commented out stuff

> +  -moz-image-region: rect(1px, 9px, 9px, 1px);
> +}
> +.toolbarbutton-up {
> +  list-style-image: url('chrome://global/skin/arrow/arrow-up.gif');
> +  padding: 0px;
> +  /*padding: 0px 0px 0px 3px;
> +  margin-bottom: -1px;*/

remove commented out stuff

> +.toolbarbutton-up:hover{

add space before {


Other things:
* The up arrow looks "garbled".

* In the testcase, if I enter a year in the input that is not in the drop down, I get these errors:

Warning: reference to undefined property this.yearsLabel
Source File: chrome://xforms/content/widgets-xul.xml
Line: 250
Error: this.yearsLabel has no properties
Source File: chrome://xforms/content/widgets-xul.xml
Line: 250

And the output is not changed according to the input.

Comment 6

[Allan Beaufour]

Attachment: screenshot

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch3

Comment 8

[Allan Beaufour]

Comment on attachment 223163 [details] [diff] [review]
patch3

With follow ups, bug 339080 and bug 339082, r=me

Comment 9

[Allan Beaufour]

Fixed on trunk.