330801 - [ad-blocking] ads made by javascript not blocked on spiegel.de

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[promo]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.2) Gecko/20060312 Camino/1.0.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.0.2) Gecko/20060312 Camino/1.0.0+

camino allows the lycos-ad on the right, only with javascript disabled it disappeared

Reproducible: Always

Comment 1

[Chris Lawson (gone)]

This goes away entirely (and harmlessly) for me if I add the following to hostperm.1:

host	image	2	quality-channel.de
host	script	2	quality-channel.de
host	object	2	quality-channel.de
host	cookie	2	quality-channel.de
host	image	2	ivwbox.de
host	script	2	ivwbox.de
host	object	2	ivwbox.de
host	cookie	2	ivwbox.de

I'm not sure if there's any way we can take care of 'em in CSS or not, but hostperm.1 is definitely the better way to go here.

cl

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think we can fix this in the default ad-blocking, and we should.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I've got rules that block this.  I'll post a combined patch in one of the bugs.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Ad-blocking rules

These are a set of rule updates that block these (spiegel) ads, the "MSN/Dove" issue from the mailing list last month, and a couple of assorted ad-servers Chris and Sam pointed out on irc.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since we're beefing up our non-US blocking (which has always been suspect), this would be nice to land for 1.0.1, too, IMO.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Håkan, if you get a chance, could you check this in (branch and trunk) for me?

Comment 7

[Håkan Waara]

Fixed on trunk+branch.

Comment 8

[promo]

lycos ad is still there
http://www.spiegel.de/politik/deutschland/0,1518,408118,00.html

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I don't see the lycos ad at all in my trunk build from yesterday (there's a microsoft ad on the left, in the story, that I'll include in the update for the myspace bug).  

What build are you using (copy from About Camino window)?  You need a trunk (1.2+) or 1.8Uni-experimental (1.0+) build, *not* anything from the "Latest Nightly" link from caminobrowser.org.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Setting this back to FIXED.

Comment 11

[Mark Mentovai]

Fixed on CAMINO_1_0_1_MINIBRANCH and MOZILLA_1_8_0_BRANCH for cycles >=1.8.0.3 (Cm >= 1.0.2).