330855 - SOAPParameters with element set cause SOAPCall::encode to throw

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

My testcase is a mess, but the fix is pretty obvious.  Setting the element property on a SOAPParameter to control its element content rather than have it generated causes SOAPCall::encode (i.e., nsSOAPMessage::Encode) to throw, since there's a little nsCOMPtr mess that causes importNode to be passed a null pointer.

I don't think there's any security risk to fixing this since the code that allows the caller to construct the entire document (setting message on nsSOAPCall) works just fine.

This code has been around for years and nobody noticed!

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Doron Rosenberg (IBM)]

Comment on attachment 215424 [details] [diff] [review]
patch

r=me

Since it seems I 'own' the module, feel free to check this into the 1.8 branch.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 215424 [details] [diff] [review]
patch

sr=jst

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in to trunk and MOZILLA_1_8_BRANCH.