Created attachment 215465 [details] [diff] [review] reporter's patch The provided patch looks correct to me.
(Although I'd probably have written the code differently to start with, using a loop over pointers rather than indices.)
11 years ago
Comment on attachment 215465 [details] [diff] [review] reporter's patch Thanks a lot for reporting this bug and providing a fix. Sigh, I looked at bug 29152, where we added this code. The initial revision of my patch did not have this bug, but in future revisions I failed to see this error when I reviewed. r=kengert Feel free to check this patch in, or I can do it Monday.
Checked in to trunk and MOZILLA_1_8_BRANCH.
Comment on attachment 215465 [details] [diff] [review] reporter's patch approved for 1.8.0 branch, a=darin for drivers
Fix checked in to MOZILLA_1_8_0_BRANCH.
v.fixed based on comments, discussion with Darin during triage meeting, and code inspection.
Chris, can you please check-in for aviary?