331091 - firefox alpha 2 has a run-a-away script on no search engines

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect, P1)

Description

[jan klopper]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060319 Firefox/2.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060319 Firefox/2.0a1

I just untarred the firefox 2 alpha 1, and after starting it up with my old profile (from 1.5), it hangs for a while, before giving a "script is running slow" message.

The script triggering this is apparently trying to find the searchengines availaible in my profile, but finding none.

Trying the searchbox in the top gives me the same results, (since there are no search engines installed)

Shouldn't we either show the user a "install your favorite search engine" option, or remove the search box from the top all together if there are no engines installed? (this will allow sys-admins to just clean out the search-engine folder without crashing the foxes on their clients pc's.

Or we could just search on the local page, if there are no search engines installed. like with crtl-F

Reproducible: Always

Steps to Reproduce:
1.untar firefox 2.0 aplha 1
2.start
3.notice severe slowdown, and slow script message
4.notice that there are no searchengines available
5.try a search
6.notice severe slowdown, and slow script message
7.notice there's no message allowing us to install a searchengine.
Actual Results:  
firefox slows down, and afther allowing me to cancel the search script, it obviously doesn't search (anywere)

Expected Results:  
search the local page,
or let me know there are no engines installed, and let me pick from a list to install.
Or remove the box from the top altogether disabling me to even try a search.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Although I have only WinXP to test and no Linux, I see no difference in the initial startup time with and without search engines in the profile.
I do see difference when I compare the latest trunk with 1.5.0.1 (7 seconds for 1.5.0.1 and 13 seconds for trunk both without an existing profile), but this is probably due to places and not to search engines.
But maybe this search engine problem is Linux-only.

Comment 2

[jan klopper]

(In reply to comment #1)
> Although I have only WinXP to test and no Linux, I see no difference in the
> initial startup time with and without search engines in the profile.
> I do see difference when I compare the latest trunk with 1.5.0.1 (7 seconds for
> 1.5.0.1 and 13 seconds for trunk both without an existing profile), but this is
> probably due to places and not to search engines.
> But maybe this search engine problem is Linux-only.
> 

Hmm after checking again,

There are plugins in the searchplugins folder, but don't get listed.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

There are always going to be search engines installed, since 6 engines are shipped with Firefox. Could you try setting browser.search.log and javascript.options.showInConsole to "true" using about:config, and then looking in the javascript console for any error messages?

Comment 4

[jan klopper]

Attachment: CLI log

Comment 5

[jan klopper]

Attachment: error message during load (after allowing the script to run)

This error is given after i continue the script. and thus follows the confirm dialog. It is followed by an other confirm dialog asking me stop stop a run-away script again.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Ah, this is probably a dupe of bug 330842, though that doesn't explain the long delays at startup. How many profile search plugins do you have?

Comment 7

[jan klopper]

(In reply to comment #6)
> Ah, this is probably a dupe of bug 330842, though that doesn't explain the long
> delays at startup. How many profile search plugins do you have?
> 

Hi, hmm could be, (did check the bug-list for 2.0 Alpha, but it only had 10 bugs then :P

I have just two extra search-plugins.
I'm not sure what is happening in the JS converting the plugins but firefox noticed the run-away script and thus asks me if i'd like to stop the slow script, if i stop it the gui loads, if i allow it to run, i get the screencapped error. In both cases there are no search engines available.

It does look like a Dupe of bug 330842 indeed, But maybe there's something more wrong with my extra search scripts why its looping.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> It does look like a Dupe of bug 330842 indeed, But maybe there's something more
> wrong with my extra search scripts why its looping.

Could you send me the files in your profile searchplugins directory? I could try and see if I can reproduce the problem locally.

Comment 9

[jan klopper]

Attachment: Search plugins from 1.5 profile.

These are the plugins from the Firefox 1.5 profile folder.

Two of them search on a password protected site, so they'l tell you to login.

Comment 10

[jan klopper]

I just downloaded the bon echo build.

Same problem.

But i also tried a couple of different scenarios.
Having no custom *.src search plugins works as it should. I get all the normal search engines.

Having 1 custom src file and jpg icon, works as it should., gives me all the normal search engines. And the one i added.

Having 2 or more custom src files and jpg icons (or no icons) gives me the slow script error, and the strace outpout window.

Having one custom src and icon, and one allready converted xml file also crashes  like having more than one custom search script.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Jan, do you think you could try and reproduce this issue again, now that bug 330842 is fixed? You'd need to have something resembling your old profile, I guess.

Comment 12

[jan klopper]

(In reply to comment #11)
> Jan, do you think you could try and reproduce this issue again, now that bug
> 330842 is fixed? You'd need to have something resembling your old profile, I
> guess.
> 

Sure, could you point me to a build which has this fixed? I am unsure which tar to download, (a linux 386 build)

Comment 13

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #12)
> Sure, could you point me to a build which has this fixed? I am unsure which tar
> to download, (a linux 386 build)

Sorry Jan, I somehow missed your reply. You can try any of the builds in http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8/ .

Comment 14

[jan klopper]

(In reply to comment #13)
> (In reply to comment #12)
> > Sure, could you point me to a build which has this fixed? I am unsure which tar
> > to download, (a linux 386 build)
> 
> Sorry Jan, I somehow missed your reply. You can try any of the builds in
> http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8/ .
> 
Okay, tested it with:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060428 BonEcho/2.0a1

I attached the cli log.

BonEcho updates and installes some of the extentions, restarts en then gives me a run-away-script dialog, allowing the script to run takes about 2 more secconds, and then spwans the bonecho window.
The search-engine box only says: manage search engines, and thus has not imported any old search engines from my profile. Nor has is added google etc.

Comment 15

[jan klopper]

Attachment: Cli log for Gecko/20060428 BonEcho/2.0a1 importing search engines.

Comment 16

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #15)
> Created an attachment (id=220125) [edit]
> Cli log for Gecko/20060428 BonEcho/2.0a1 importing search engines.

That logs seems to show success: the shipped-by-default engines are loaded successfully, and then the "R Payments" plugin in your profile is converted and also loaded successfully. Are there any JS errors in the JavaScript console, if you set javascript.options.showInConsole to true using about:config?

Comment 17

[:Gavin Sharp [email: [e-mail]]]

Jan, can you still reproduce problems with the Sherlock import code? Should this bug be closed?

Comment 18

[jan klopper]

Gavin,

Il check this on monday, i don't have the correct firefox profile dir over here,. its on my work pc.

Comment 19

[jan klopper]

(In reply to comment #17)
> Jan, can you still reproduce problems with the Sherlock import code? Should
> this bug be closed?
> 

Gavin,

Just tested the following build:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2006-05-21-09-firefox1.5.0.4/

And it works like a charm. Thanks.

Comment 20

[:Gavin Sharp [email: [e-mail]]]

Marking WORKSFORME, since I don't actually know what fixed it. Thanks for the feedback, Jan!