Closed
Bug 331118
Opened 19 years ago
Closed 19 years ago
Copy .src files to dist/bin/searchplugins until all search engines can be converted
Categories
(Firefox Build System :: General, defect, P1)
Firefox Build System
General
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla2 alpha2
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file, 2 obsolete files)
|
2.17 KB,
patch
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 2 alpha1
|
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Target Milestone: Firefox 2 alpha1 → Firefox 2 alpha2
|
|
Assignee | |
Comment 2•19 years ago
|
||
This patch makes it copy all xml files if they exist, and falls back to copying src/gif/png files from list.txt otherwise. This means that .xml files are not validated against list.txt, but I'm not sure that that is a big issue given that this is just a temporary fix. I don't know how to check whether or not all files in a list exist.
Attachment #215677 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 215717 [details] [diff] [review]
patch v2
Per discussion on #l10n, I want to land this to fix l10n builds until they can be converted to using the new plugin format, once it is finalized. The search service handles .src files just fine so having a mix of formats (or one or the other) in dist/bin/searchplugins shouldn't be a problem.
Attachment #215717 -
Flags: review?(benjamin)
Attachment #215717 -
Flags: approval-branch-1.8.1?(benjamin)
|
|
Assignee | |
Updated•19 years ago
|
Priority: -- → P1
|
||
Comment 4•19 years ago
|
||
Comment on attachment 215717 [details] [diff] [review]
patch v2
So we don't want to install the images if the .xml is present? I think you want to use := in the SEARCH_*_FILES assignments so we don't reevaluate the wildcard each time the variable is used. r=me with that change
Attachment #215717 -
Flags: review?(benjamin)
Attachment #215717 -
Flags: review+
Attachment #215717 -
Flags: approval-branch-1.8.1?(benjamin)
Attachment #215717 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 5•19 years ago
|
||
(In reply to comment #4)
> (From update of attachment 215717 [details] [diff] [review] [edit])
> So we don't want to install the images if the .xml is present?
Correct. The .xml files have no associated icon files (since the icon is in the XML file), so this isn't a problem.
> I think you want to use := in the SEARCH_*_FILES assignments so we don't
> reevaluate the wildcard each time the variable is used. r=me with that change
Will do.
|
|
Assignee | |
Comment 6•19 years ago
|
||
Attachment #215717 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•19 years ago
|
||
Sorry for the delay, I just checked this in branch and trunk.
mozilla/browser/locales/Makefile.in 1.25.2.8
mozilla/browser/locales/Makefile.in 1.38
|
|
Assignee | |
Comment 8•19 years ago
|
||
These changes were backed out in bug 339783.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
|
||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
|
||
Updated•6 years ago
|
Keywords: verified1.8.1
Target Milestone: Firefox 2 alpha2 → mozilla2 alpha2
You need to log in
before you can comment on or make changes to this bug.
Description
•