331129 - linux doesn't build.

Status: RESOLVED FIXED

(Minimo Graveyard :: Build Config, defect)

Description

[Doug Turner (:dougt)]

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 215693 [details] [diff] [review]
patch v.1

ignore the change to embedding/Makefile.in.  this should NOT be included.

Comment 3

[Antonio Gomes (tonikitoo)]

(In reply to comment #2)
> (From update of attachment 215693 [details] [diff] [review] [edit])
> ignore the change to embedding/Makefile.in.  this should NOT be included.
> 

I got this ...

nsStaticComponents.cpp
nsStaticComponents.o(.rodata+0x3c): undefined reference to `necko_NSGetModule(nsIComponentManager*, nsIFile*, nsIModule**)'
collect2: ld returned 1 exit status
make[4]: *** [minimo] Error 1
make[3]: *** [libs] Error 2
make[2]: *** [tier_99] Error 2
make[1]: *** [default] Error 2
make: *** [build] Error 2

Comment 4

[Antonio Gomes (tonikitoo)]

It builds now  !

minimo runs PRETTY good, great job !

TestGtkEmbed crashes though

gdb ./minimo 

Starting program: /home/agomes/MozillaDevel/sources/mozilla/make_install/lib/minimo-0.013/TestGtkEmbed r www
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
(no debugging symbols found)
[Thread debugging using libthread_db enabled]
[New Thread -1219717440 (LWP 4731)]
new_gtk_browser
        menu bar
        tool bar
        location bar
        status bar

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1219717440 (LWP 4731)]
0x080567ba in ?? ()
(gdb) up
#1  0x08112d00 in ?? ()
(gdb)
#2  0xbf96dc04 in ?? ()
(gdb)
#3  0xb77ced23 in operator delete () from /usr/lib/libstdc++.so.5
(gdb)



(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 215693 [details] [diff] [review] [edit] [edit])
> > ignore the change to embedding/Makefile.in.  this should NOT be included.
> > 
> 
> I got this ...
> 
> nsStaticComponents.cpp
> nsStaticComponents.o(.rodata+0x3c): undefined reference to
> `necko_NSGetModule(nsIComponentManager*, nsIFile*, nsIModule**)'
> collect2: ld returned 1 exit status
> make[4]: *** [minimo] Error 1
> make[3]: *** [libs] Error 2
> make[2]: *** [tier_99] Error 2
> make[1]: *** [default] Error 2
> make: *** [build] Error 2
> 

How could I get more symbol beyond removing enable-strip config option ?

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 215693 [details] [diff] [review]
patch v.1

benjamin, can you review this change?

Comment 6

[Benjamin Smedberg]

Comment on attachment 215693 [details] [diff] [review]
patch v.1

I'm interested in the embedding/browser/gtk/src/... change... we don't do gtkmozembed static build any more unless I'm vastly mistaken.

Comment 7

[Doug Turner (:dougt)]

so, minimo does build as a static binary.  maybe we just don't support building the gtkmozembed static build when building minimo?  I would like to be able to generate a gtkmozembed from the same build tree that I use for Minimo

Comment 8

[Benjamin Smedberg]

The "static gtkmozembed" would be --enable-application=xulrunner --with-embedding-profile=minimal|basic

Which is hopefully where minimo is going as well, as we've discussed.

Comment 9

[Doug Turner (:dougt)]

Comment on attachment 215693 [details] [diff] [review]
patch v.1

we aren't there just yet.  I will make it so that if you are building minimo, you will not build the gtk embedding widget.

tonikitoo, can you verify that building the gtk widget as benjamin suggested works for you?

Comment 10

[Benjamin Smedberg]

Comment on attachment 215693 [details] [diff] [review]
patch v.1

This is ok for the 1.8 branch if you remove xpcomglue from the libs list as we discussed on IRC.

Comment 11

[Doug Turner (:dougt)]

Attachment: icon decoder bustage

Comment 12

[Doug Turner (:dougt)]

Checking in Makefile.in;
/cvsroot/mozilla/Makefile.in,v  <--  Makefile.in
new revision: 1.299.2.10; previous revision: 1.299.2.9
done
Checking in embedding/browser/gtk/src/Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/src/Makefile.in,v  <--  Makefile.in
new revision: 1.55.2.1; previous revision: 1.55
done
Checking in embedding/browser/gtk/tests/Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.33.8.1; previous revision: 1.33
done
RCS file: /cvsroot/mozilla/embedding/config/Attic/minimo-unix-libs,v
done
Checking in embedding/config/minimo-unix-libs;
/cvsroot/mozilla/embedding/config/Attic/minimo-unix-libs,v  <--  minimo-unix-libs
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in modules/libpr0n/decoders/icon/Makefile.in;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/Makefile.in,v  <--  Makefile.in
new revision: 1.17.8.4; previous revision: 1.17.8.3
done

Comment 13

[Oliver Braun]

The patch to embedding/browser/gtk/test/Makefile.in broke building without BUILD_STATIC_LIBS.

Comment 14

[Oliver Braun]

Attachment: Proposed patch to resolve BUILD_STATIC_LIBS issue

Comment 15

[Doug Turner (:dougt)]

bsmedberg warned me about this too, iirc.  Sorry for the bustage and thank you for the patch:

Checking in Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.33.8.2; previous revision: 1.33.8.1
done

Maybe we should have a non-static tbox?